Review main Merged

89807[FEATURE] Add dynamic recently used category to record wizards

Andreas Nedbal CR +2 V +2 Normal +204 −9 updated 06/26/25, 19:46

Commit message

A new "Recently used" dynamic category has been added to
record  wizards, including:

- Content elements
- Form elements
- Dashboard widgets

This dynamic section lists the most recently
used record types per user, improving discoverability
and access to frequently used items.

Review

  • Code review CR +2 Done
    • Andreas Nedbal +2
    • Oli Bartsch +1
    • Garvin Hicking +1
  • Verified V +2 Done
    • Andreas Nedbal +2
    • Oli Bartsch +1
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 1

Files 11

Review log 2636

Show 711 earlier messages
  1. Andreas Nedbal uploaded patch set 1 06/23/25, 15:37

  2. core-ci voted on patch set 1 V +1 06/23/25, 15:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80638

  3. Andreas Nedbal uploaded patch set 2 V +1 06/23/25, 15:59

  4. core-ci voted on patch set 2 V +1 06/23/25, 16:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80641

  5. Andreas Kienast commented on patch set 2 CR -1 06/24/25, 08:09

    new-record-wizard.ts:396

    Just an idea: make `type` a nullable property. If it is not null, we want to see the recently used items. This would make the `displayRecentlyUsed` flag obsolete.

    new-record-wizard.ts:429

    It looks like `itemsMap` is not required at all, `recentlyUsed` already contains the necessary items.

    record-usage-store.ts:19

    TypeScript supports constructor property assignment. ```suggestion constructor( private readonly type: string ) { } ```

    record-usage-store.ts:35

    Can be drastically shortened: ```suggestion usageData[recordIdentifier] = { lastUsed: Date.now(), count: (usageData[recordIdentifier]?.count ?? 0) + 1 }; ```

    record-usage-store.ts:40

    Where can I configure the limit? There's no property in the web component.

    record-usage-store.ts:54

    Not sure if I like this. When loading the recently used items, the "old" items are offered and suddenly get lost after saving the new data set.

    record-usage-store.ts:67

    There's no need for string interpolation here. ```suggestion return RECORD_USAGE_STORE_KEY_PREFIX + this.type; ```
  6. Andreas Nedbal uploaded patch set 3 CR -1 V +1 06/24/25, 09:39

  7. Andreas Nedbal commented on patch set 3 06/24/25, 09:43

    new-record-wizard.ts:396 Reply

    Done

    new-record-wizard.ts:429 Reply

    Done

    record-usage-store.ts:19 Reply

    Done

    record-usage-store.ts:35 Reply

    Done

    record-usage-store.ts:40 Reply

    Done

    record-usage-store.ts:54 Reply

    Moved the logic to remove old items when loading the list now.

    record-usage-store.ts:67 Reply

    Done
  8. core-ci voted on patch set 3 V +1 06/24/25, 09:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80714

  9. Benjamin Kott uploaded patch set 4 V +1 06/24/25, 19:15

  10. core-ci voted on patch set 4 V +1 06/24/25, 19:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80794

  11. Benjamin Franzke uploaded patch set 5 V +1 06/24/25, 20:30

  1. core-ci voted on patch set 5 V +1 06/24/25, 20:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80805

  2. Benjamin Franzke uploaded patch set 6 V +1 06/24/25, 20:40

  3. core-ci voted on patch set 6 V +1 06/24/25, 20:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80807

  4. Benjamin Kott voted on patch set 6 CR +1 V +1 06/25/25, 07:02

  5. Andreas Kienast commented on patch set 6 V -1 06/25/25, 07:30

    The wizard for content elements is broken for me: > Uncaught (in promise) TypeError: Cannot convert undefined or null to object
  6. Andreas Kienast commented on patch set 6 CR +1 V +1 06/25/25, 07:31

    Reply

    Never mind, I had broken data from a former state of the patch.
  7. Benjamin Franzke commented on patch set 6 06/25/25, 07:37

    I don't quite like that we immediately "jump" into the "Recently used" category. This feels wrong, that General is now "always" a click away. I'd rather prefer to open the "last" category instead.
  8. Benjamin Franzke commented on patch set 6 CR -1 06/25/25, 07:37

    Reply

    -1 to block for clarification of this topic
  9. Andreas Nedbal updated the commit message in patch set 7 CR +1 V +1 06/25/25, 09:28

  10. Andreas Nedbal commented on patch set 7 CR -2 06/25/25, 09:29

    do not merge yet, testing/clarifications needed
  11. core-ci voted on patch set 7 V +1 06/25/25, 09:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80832

  12. Oli Bartsch commented on patch set 7 06/25/25, 10:12

    I would like this to be a FEATURE since it improves workflow efficiency and usability.
  13. Andreas Nedbal uploaded patch set 8 V +1 06/26/25, 15:06

    Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**")
  14. Andreas Nedbal voted on patch set 8 CR 0 06/26/25, 15:07

  15. Andreas Nedbal commented on patch set 8 06/26/25, 15:07

    Reply

    Done
  16. core-ci voted on patch set 8 V +1 06/26/25, 15:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80995

  17. Andreas Nedbal uploaded patch set 9 V +1 06/26/25, 16:58

  18. core-ci voted on patch set 9 V +1 06/26/25, 17:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81002

  19. Oli Bartsch uploaded patch set 10 V +1 06/26/25, 18:34

  20. Oli Bartsch voted on patch set 10 CR +1 V +1 06/26/25, 18:35

  21. Oli Bartsch commented on patch set 10 06/26/25, 18:35

    Reply

    Done
  22. core-ci voted on patch set 10 V +1 06/26/25, 18:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81009

  23. Garvin Hicking commented on patch set 10 CR +1 V +1 06/26/25, 19:41

    Tested on macOS, Firefox+chromium+Safari. Quite helpful! :-)
  24. Andreas Nedbal voted on patch set 10 CR +2 V +2 06/26/25, 19:46

  25. Andreas Nedbal merged patch set 11 06/26/25, 19:46