89807[FEATURE] Add dynamic recently used category to record wizards
Commit message
Review
-
Code review CR +2 Done
- Andreas Nedbal +2
- Oli Bartsch +1
- Garvin Hicking +1
-
Verified V +2 Done
- Andreas Nedbal +2
- Oli Bartsch +1
- Garvin Hicking +1
- core-ci +1 CI
Issues 1
Files 11
- Build/Sources/TypeScript/backend/record-usage/record-usage-store.ts10new+65 −0
- Build/Sources/TypeScript/backend/storage/abstract-client-storage.ts+1 −1
- Build/Sources/TypeScript/backend/new-record-wizard.ts4+69 −5
- Build/Sources/TypeScript/dashboard/dashboard.ts+1 −0
- typo3/sysext/backend/Resources/Private/Templates/NewContentElement/Wizard.html+6 −1
- typo3/sysext/backend/Resources/Public/JavaScript/record-usage/record-usage-store.jsnew+13 −0
- typo3/sysext/backend/Resources/Public/JavaScript/new-record-wizard.js+1 −1
- typo3/sysext/core/Documentation/Changelog/14.0/Feature-106934-AddRecentlyUsedRecordsToRecordWizards.rstnew+43 −0
- typo3/sysext/core/Resources/Private/Language/locallang_misc.xlf+3 −0
- typo3/sysext/dashboard/Resources/Public/JavaScript/dashboard.js+1 −1
- typo3/sysext/form/Resources/Private/Backend/Partials/FormEditor/Modals/InsertElements.html+1 −0
Review log 2636
Show 711 earlier messages
-
Andreas Nedbal uploaded patch set 1 06/23/25, 15:37
-
core-ci voted on patch set 1 V +1 06/23/25, 15:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80638
-
Andreas Nedbal uploaded patch set 2
V +106/23/25, 15:59 -
core-ci voted on patch set 2 V +1 06/23/25, 16:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80641
-
Andreas Kienast commented on patch set 2 CR -1 06/24/25, 08:09
new-record-wizard.ts:429It looks like `itemsMap` is not required at all, `recentlyUsed` already contains the necessary items.record-usage-store.ts:19TypeScript supports constructor property assignment. ```suggestion constructor( private readonly type: string ) { } ```record-usage-store.ts:35Can be drastically shortened: ```suggestion usageData[recordIdentifier] = { lastUsed: Date.now(), count: (usageData[recordIdentifier]?.count ?? 0) + 1 }; ```record-usage-store.ts:40Where can I configure the limit? There's no property in the web component.record-usage-store.ts:54Not sure if I like this. When loading the recently used items, the "old" items are offered and suddenly get lost after saving the new data set.record-usage-store.ts:67There's no need for string interpolation here. ```suggestion return RECORD_USAGE_STORE_KEY_PREFIX + this.type; ``` -
Andreas Nedbal uploaded patch set 3
CR -1V +106/24/25, 09:39 -
Andreas Nedbal commented on patch set 3 06/24/25, 09:43
new-record-wizard.ts:396ReplyDonenew-record-wizard.ts:429ReplyDonerecord-usage-store.ts:19ReplyDonerecord-usage-store.ts:35ReplyDonerecord-usage-store.ts:40ReplyDonerecord-usage-store.ts:54ReplyMoved the logic to remove old items when loading the list now.record-usage-store.ts:67ReplyDone -
core-ci voted on patch set 3 V +1 06/24/25, 09:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80714
-
Benjamin Kott uploaded patch set 4
V +106/24/25, 19:15 -
core-ci voted on patch set 4 V +1 06/24/25, 19:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80794
-
Benjamin Franzke uploaded patch set 5
V +106/24/25, 20:30
-
core-ci voted on patch set 5 V +1 06/24/25, 20:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80805
-
Benjamin Franzke uploaded patch set 6
V +106/24/25, 20:40 -
core-ci voted on patch set 6 V +1 06/24/25, 20:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80807
-
Benjamin Kott voted on patch set 6 CR +1 V +1 06/25/25, 07:02
-
Andreas Kienast commented on patch set 6 V -1 06/25/25, 07:30
The wizard for content elements is broken for me: > Uncaught (in promise) TypeError: Cannot convert undefined or null to object -
Andreas Kienast commented on patch set 6 CR +1 V +1 06/25/25, 07:31
Reply
Never mind, I had broken data from a former state of the patch. -
Benjamin Franzke commented on patch set 6 06/25/25, 07:37
I don't quite like that we immediately "jump" into the "Recently used" category. This feels wrong, that General is now "always" a click away. I'd rather prefer to open the "last" category instead. -
Benjamin Franzke commented on patch set 6 CR -1 06/25/25, 07:37
Reply
-1 to block for clarification of this topic -
Andreas Nedbal updated the commit message in patch set 7
CR +1V +106/25/25, 09:28 -
Andreas Nedbal commented on patch set 7 CR -2 06/25/25, 09:29
do not merge yet, testing/clarifications needed -
core-ci voted on patch set 7 V +1 06/25/25, 09:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80832
-
Oli Bartsch commented on patch set 7 06/25/25, 10:12
I would like this to be a FEATURE since it improves workflow efficiency and usability. -
Andreas Nedbal uploaded patch set 8
V +106/26/25, 15:06Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**") -
Andreas Nedbal voted on patch set 8 CR 0 06/26/25, 15:07
-
Andreas Nedbal commented on patch set 8 06/26/25, 15:07
Reply
Done -
core-ci voted on patch set 8 V +1 06/26/25, 15:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80995
-
Andreas Nedbal uploaded patch set 9
V +106/26/25, 16:58 -
core-ci voted on patch set 9 V +1 06/26/25, 17:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81002
-
Oli Bartsch uploaded patch set 10
V +106/26/25, 18:34 -
Oli Bartsch voted on patch set 10 CR +1 V +1 06/26/25, 18:35
-
Oli Bartsch commented on patch set 10 06/26/25, 18:35
Reply
Done -
core-ci voted on patch set 10 V +1 06/26/25, 18:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81009
-
Garvin Hicking commented on patch set 10 CR +1 V +1 06/26/25, 19:41
Tested on macOS, Firefox+chromium+Safari. Quite helpful! :-) -
Andreas Nedbal voted on patch set 10 CR +2 V +2 06/26/25, 19:46
-
Andreas Nedbal merged patch set 11 06/26/25, 19:46
new-record-wizard.ts:396