Review main Merged

89810[TASK] Streamline stage change notification in workspace

Benni Mack CR +2 V +2 Normal +90 −43 updated 06/25/25, 06:19

Commit message

This change adapts a few places when notifying
users of a stage change:

1. It delivers the full record to the stage change notification
2. It triggers the stage notification even if no email recipient is selected
   so alternative handlers can actually use the Notification (e.g. to Slack)
3. It adds some minor adaptions to remove the "Email" claim from a notification in some internal variables
4. It unifies the ugly array, which can then be improved at a separate step

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Stefan Bürk +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Benni Mack +2
    • Stefan Bürk +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 1115

  1. Benni Mack uploaded patch set 1 06/23/25, 16:15

  2. core-ci voted on patch set 1 V -1 06/23/25, 16:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80643

  3. Benni Mack uploaded patch set 2 V -1 06/23/25, 16:42

  4. core-ci voted on patch set 2 V +1 06/23/25, 16:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80650

  5. Benni Mack updated the commit message in patch set 3 V +1 06/23/25, 18:25

  6. core-ci voted on patch set 3 V +1 06/23/25, 18:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80653

  7. Christian Kuhn commented on patch set 3 06/23/25, 18:59

    DataHandlerHook.php:152

    can't we have this getRecord even earlier and store the full thing in $this->notificationInfo up-front?

    DataHandlerHook.php:651

    could we hand over $this->notificationInfo to avoid accessing $this in the helper method? (I'm a fan of moving access to class properties as much "up" as possible to not spread the cancer of changing class state into helper methods. This makes it easier to refactor state away later).
  8. Christian Kuhn commented on patch set 3 06/23/25, 19:01

    DataHandlerHook.php:651 Reply

    "helper method" = "lower level methods": Have state changes on top/high level methods and don't access $this properties in lower levels. I found this strategy to be helpful in general when it comes to "taming" state.
  9. Benni Mack uploaded patch set 4 V +1 06/24/25, 15:49

  10. Benni Mack commented on patch set 3 06/24/25, 15:50

    DataHandlerHook.php:152 Reply

    this is a bit more complicated, I'd add this to the next batch of working with notifications.

    DataHandlerHook.php:651 Reply

    Done
  11. core-ci voted on patch set 4 V +1 06/24/25, 15:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80768

  12. Christian Kuhn voted on patch set 4 CR +1 V +1 06/24/25, 21:57

  13. Stefan Bürk voted on patch set 4 CR +1 V +1 06/24/25, 23:21

  14. Benni Mack voted on patch set 4 CR +2 V +2 06/25/25, 06:14

  15. Benni Mack merged patch set 5 06/25/25, 06:19