89810[TASK] Streamline stage change notification in workspace
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Stefan Bürk +1
- Christian Kuhn +1
-
Verified V +2 Done
- Benni Mack +2
- Stefan Bürk +1
- Christian Kuhn +1
- core-ci +1 CI
Issues 1
Files 4
- typo3/sysext/workspaces/Classes/Hook/DataHandlerHook.php5+77 −38
- typo3/sysext/workspaces/Classes/Notification/StageChangeNotification.php+11 −3
- typo3/sysext/workspaces/Resources/Private/Templates/Email/StageChangeNotification.html+1 −1
- typo3/sysext/workspaces/Resources/Private/Templates/Email/StageChangeNotification.txt+1 −1
Review log 1115
-
Benni Mack uploaded patch set 1 06/23/25, 16:15
-
core-ci voted on patch set 1 V -1 06/23/25, 16:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80643
-
Benni Mack uploaded patch set 2
V -106/23/25, 16:42 -
core-ci voted on patch set 2 V +1 06/23/25, 16:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80650
-
Benni Mack updated the commit message in patch set 3
V +106/23/25, 18:25 -
core-ci voted on patch set 3 V +1 06/23/25, 18:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80653
-
Christian Kuhn commented on patch set 3 06/23/25, 18:59
DataHandlerHook.php:651could we hand over $this->notificationInfo to avoid accessing $this in the helper method? (I'm a fan of moving access to class properties as much "up" as possible to not spread the cancer of changing class state into helper methods. This makes it easier to refactor state away later). -
Christian Kuhn commented on patch set 3 06/23/25, 19:01
DataHandlerHook.php:651Reply"helper method" = "lower level methods": Have state changes on top/high level methods and don't access $this properties in lower levels. I found this strategy to be helpful in general when it comes to "taming" state. -
Benni Mack uploaded patch set 4
V +106/24/25, 15:49 -
Benni Mack commented on patch set 3 06/24/25, 15:50
DataHandlerHook.php:152Replythis is a bit more complicated, I'd add this to the next batch of working with notifications.DataHandlerHook.php:651ReplyDone -
core-ci voted on patch set 4 V +1 06/24/25, 15:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80768
-
Christian Kuhn voted on patch set 4 CR +1 V +1 06/24/25, 21:57
-
Stefan Bürk voted on patch set 4 CR +1 V +1 06/24/25, 23:21
-
Benni Mack voted on patch set 4 CR +2 V +2 06/25/25, 06:14
-
Benni Mack merged patch set 5 06/25/25, 06:19
DataHandlerHook.php:152