Review 13.4 Merged

89814[BUGFIX] Account for fake UTC-0 datetime strings in readonly elements

Benjamin Franzke CR +2 V +2 Easy +4 −0 updated 07/02/25, 10:37

Commit message

In order to pass in correct unix timestamps, the DatetimeElement
needs to account for fake UTC-0 offsets in datetime strings that
have been prepared and normalized to fake UTC-0 in native datetime
format provider `FormDataProvider/DatabaseRowDateTimeFields`.

Note: For TYPO3 v14 this has been fixed in #105549 by removing the fake
UTC-0 handling in favor of unqualified localtime, which does not require
this normalization.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Garvin Hicking +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Garvin Hicking +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 911

  1. Benjamin Franzke uploaded patch set 1 06/23/25, 20:31

  2. core-ci voted on patch set 1 V +1 06/23/25, 20:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80658

  3. Garvin Hicking commented on patch set 1 CR +1 V +1 06/23/25, 20:49

    This works in my test-instances (v13+v12), tested with EXT:styleguide inputdatetime_4 which I first populated, then set to readOnly=>true and which was at 06:42 before the patch and 05:42 after the patch (the same as regular input shows)
  4. Stefan Bürk voted on patch set 1 CR +1 V +1 06/24/25, 23:44

  5. Benjamin Franzke updated the commit message in patch set 2 CR +1 V +1 06/25/25, 10:34

  6. Benjamin Franzke commented on patch set 2 06/25/25, 10:35

    12.4 is not affected because offsets were exposed differently. Therefore I discarded the backport.
  7. core-ci voted on patch set 2 V +1 06/25/25, 10:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80841

  8. Garvin Hicking voted on patch set 2 CR +1 V +1 06/25/25, 13:14

  9. Stefan Bürk voted on patch set 2 CR +1 V +1 07/02/25, 09:15

  10. Benjamin Franzke voted on patch set 2 CR +2 V +2 07/02/25, 10:37

  11. Benjamin Franzke merged patch set 3 07/02/25, 10:37