Review main Merged

89815[BUGFIX] Respect TSconfig disableButtonForDokType everywhere

Benni Mack CR +2 V +2 Normal +108 −125 updated 06/24/25, 10:58

Commit message

This change is the first in a series of patches to
streamline preview link generation.

This first patch puts the logic what kind of page preview links
can be generated into one spot: The PreviewUriBuilder.

Thus, the TSconfig option TCEMAIN.preview.disableButtonForDokType
is always respected, and this means that the icon is now
removed in Page module for sysfolders etc.

The PreviewUriBuilder can now receive a array instead
of just the Page ID, reducing the calling code logic
drastically.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 23

Show 3 more files

Review log 1117

  1. Benni Mack uploaded patch set 1 06/23/25, 20:33

  2. Benni Mack updated the commit message in patch set 2 06/23/25, 20:36

  3. core-ci voted on patch set 1 V -1 06/23/25, 20:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80659

  4. core-ci voted on patch set 2 V -1 06/23/25, 20:48 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80660

  5. Benni Mack uploaded patch set 3 V -1 06/23/25, 21:04

  6. core-ci voted on patch set 3 V -1 06/23/25, 21:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80664

  7. Benni Mack uploaded patch set 4 V -1 06/23/25, 21:31

  8. core-ci voted on patch set 4 V +1 06/23/25, 21:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80668

  9. Oli Bartsch uploaded patch set 5 V +1 06/24/25, 08:46

  10. core-ci voted on patch set 5 V -1 06/24/25, 08:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80701

  11. Oli Bartsch uploaded patch set 6 V -1 06/24/25, 09:12

  12. core-ci voted on patch set 6 V +1 06/24/25, 09:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80706

  13. Oli Bartsch voted on patch set 6 CR +1 V +1 06/24/25, 09:22

  14. Stefan Bürk voted on patch set 6 CR +1 06/24/25, 09:45

  15. Stefan Bürk voted on patch set 6 V +1 06/24/25, 09:51

  16. Oli Bartsch voted on patch set 6 CR +2 V +2 06/24/25, 10:58

  17. Oli Bartsch merged patch set 7 06/24/25, 10:58