Review main Merged

89823[FEATURE] Add "discard" command to DataHandler

Benni Mack CR +2 V +2 Normal +133 −8 updated 09/25/25, 13:28

Commit message

DataHandler now has a new "command" called "discard"
to remove elements in a workspace and discard its work
forever.

Previously this was handled via the "clearWSID" and
"flush" action parameter within the "version" command,
acting as "subcommands".

The previous action parameters are kept without deprecation
as it was implemented in Testing Framework and is
still around for a while. Although not documented,
they are considered internal, they are still available.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 1318

  1. Benni Mack uploaded patch set 1 06/23/25, 22:24

  2. core-ci voted on patch set 1 V +1 06/23/25, 22:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80672

  3. Benni Mack marked it work in progress 06/24/25, 10:40

  4. Benni Mack uploaded patch set 2 V +1 09/22/25, 15:09

  5. core-ci voted on patch set 2 V +1 09/22/25, 15:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85309

  6. Benni Mack uploaded patch set 3 V +1 09/24/25, 14:51

  7. Benni Mack marked it ready for review 09/24/25, 14:51

  8. core-ci voted on patch set 3 V -1 09/24/25, 14:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85453

  9. Benni Mack commented on patch set 4 V -1 09/24/25, 15:02

    Published edit on patch set 3.
  10. core-ci voted on patch set 4 V +1 09/24/25, 15:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85454

  11. Benni Mack commented on patch set 5 V +1 09/24/25, 15:56

    Published edit on patch set 4.
  12. core-ci voted on patch set 5 V +1 09/24/25, 16:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85461

  13. Oli Bartsch commented on patch set 5 09/24/25, 17:34

    CommandMap.php:208

    Should add a deprecation log entry here?
  14. Benni Mack commented on patch set 5 09/24/25, 18:15

    CommandMap.php:208 Reply

    Testing framework is still using this, if we'd add deprecation log entry, test would fail.
  15. Oli Bartsch voted on patch set 5 CR +1 V +1 09/25/25, 12:35

  16. Christian Kuhn voted on patch set 5 CR +1 V +1 09/25/25, 13:25

  17. Benni Mack voted on patch set 5 CR +2 V +2 09/25/25, 13:28

  18. Benni Mack merged patch set 6 09/25/25, 13:28