89824[FEATURE] Add "publish" command to DataHandler
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Georg Ringer +1
- Wouter Wolters +1
- Simon Schaufelberger +1
-
Verified V +2 Done
- Benni Mack +2
- Georg Ringer +1
- Wouter Wolters +1
- Simon Schaufelberger +1
- core-ci +1 CI
Issues 1
Files 13
- Build/Sources/TypeScript/workspaces/backend.ts+17 −4
- Build/Sources/TypeScript/workspaces/preview.ts+14 −2
- typo3/sysext/core/Documentation/Changelog/15.0/Feature-108649-IntroducePublishCommandForWorkspaces.rstnew+120 −0
- typo3/sysext/workspaces/Classes/Controller/ReviewController.php+1 −0
- typo3/sysext/workspaces/Classes/Controller/WorkspacesAjaxController.php+132 −52
- typo3/sysext/workspaces/Classes/DataHandler/CommandMap.php2+31 −36
- typo3/sysext/workspaces/Classes/Domain/Repository/WorkspaceStageRepository.php+1 −0
- typo3/sysext/workspaces/Classes/Hook/DataHandlerHook.php+37 −1
- typo3/sysext/workspaces/Classes/Service/StagesService.php+8 −2
- typo3/sysext/workspaces/Classes/Service/WorkspaceService.php+9 −8
- typo3/sysext/workspaces/Resources/Public/JavaScript/backend.js+1 −1
- typo3/sysext/workspaces/Resources/Public/JavaScript/preview.js+1 −1
- typo3/sysext/workspaces/Tests/Functional/DataHandler/PublishCommandTest.phpnew+189 −0
Review log 3757
Show 1832 earlier messages
-
Benni Mack uploaded patch set 1 06/23/25, 22:50
-
Benni Mack marked it work in progress 06/23/25, 22:51
-
core-ci voted on patch set 1 V -1 06/23/25, 23:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80673
-
Benni Mack uploaded patch set 2
V -109/22/25, 15:13 -
core-ci voted on patch set 2 V -1 09/22/25, 15:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85310
-
Benni Mack commented on patch set 3
V -109/22/25, 19:50Published edit on patch set 2. -
Benni Mack commented on patch set 4 09/22/25, 19:50
Published edit on patch set 3. -
core-ci voted on patch set 3 V -1 09/22/25, 20:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85341
-
core-ci voted on patch set 4 V -1 09/22/25, 20:10 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85342
-
Benni Mack uploaded patch set 5
V -109/24/25, 15:37 -
core-ci voted on patch set 5 V +1 09/24/25, 15:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85458
-
Benni Mack uploaded patch set 6
V +109/26/25, 13:13 -
Benni Mack updated the commit message in patch set 7 09/26/25, 13:14
-
core-ci voted on patch set 6 V -1 09/26/25, 13:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85608
-
core-ci voted on patch set 7 V -1 09/26/25, 13:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85609
-
Benni Mack uploaded patch set 8
V -109/26/25, 14:38 -
core-ci voted on patch set 8 V -1 09/26/25, 14:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85614
-
Benni Mack uploaded patch set 9
V -109/26/25, 16:34 -
core-ci voted on patch set 9 V -1 09/26/25, 16:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85620
-
Benni Mack uploaded patch set 10
V -109/29/25, 08:30 -
core-ci voted on patch set 10 V -1 09/29/25, 08:40 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85689
-
Benni Mack uploaded patch set 11
V -101/15/26, 21:55 -
core-ci voted on patch set 11 V -1 01/15/26, 22:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93536
-
Benni Mack uploaded patch set 12
V -101/15/26, 22:11 -
Benni Mack updated the commit message in patch set 13 01/15/26, 22:11
-
core-ci voted on patch set 12 V +1 01/15/26, 22:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93537
-
core-ci voted on patch set 13 V +1 01/15/26, 22:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93538
-
Benni Mack uploaded patch set 14
V +101/24/26, 19:48 -
Benni Mack marked it ready for review 01/24/26, 19:50
-
core-ci voted on patch set 14 V +1 01/24/26, 19:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94268
-
Simon Schaufelberger commented on patch set 14 01/24/26, 20:18
Feature-108649-IntroducePublishCommandForWorkspaces.rst:108please don't overuse php prefixes here as this is just a simple string and no php code.Feature-108649-IntroducePublishCommandForWorkspaces.rst:116please don't overuse php prefixes here as this is just a simple string and no php code. -
Benni Mack commented on patch set 15
V +101/25/26, 08:39Published edit on patch set 14.
-
Benni Mack commented on patch set 15 01/25/26, 08:44
Feature-108649-IntroducePublishCommandForWorkspaces.rst:108ReplyDoneFeature-108649-IntroducePublishCommandForWorkspaces.rst:116ReplyDone -
core-ci voted on patch set 15 V +1 01/25/26, 08:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94296
-
Simon Schaufelberger voted on patch set 15 CR +1 01/25/26, 09:38
-
Anja Leichsenring voted on patch set 15 CR +1 V +1 02/01/26, 11:38
-
Oliver Hader commented on patch set 15 02/10/26, 15:16
CommandMap.php:83I'm not sure about this one... the elements here are used to resolve nested dependencies... using the version-id here without having to adjust any other underlying components (see `TYPO3\CMS\Workspaces\Dependency`) does not "feel" correct -
Anja Leichsenring uploaded patch set 16
CR +1V +103/03/26, 08:13 -
Anja Leichsenring commented on patch set 16 03/03/26, 08:14
rebased only, Ollys remark is still in effect. -
core-ci voted on patch set 16 V +1 03/03/26, 08:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97157
-
Simon Schaufelberger uploaded patch set 17
V +103/27/26, 09:05 -
core-ci voted on patch set 17 V +1 03/27/26, 09:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98845
-
Simon Schaufelberger rebased onto patch set 18
V +108/13/26, 10:22 -
core-ci voted on patch set 18 V +1 08/13/26, 10:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106638
-
Benni Mack uploaded patch set 19
V +109/04/26, 14:39 -
Benni Mack commented on patch set 19 09/04/26, 14:40
CommandMap.php:83ReplyThe dependency layer is already version-id based:: - ElementEntity::$id is the versioned uid in both paths — the legacy version command passed swapWith (the version uid) as the constructor argument too. liveId is derived data, resolved in resolveWorkspaceState(). - getChildren()/getParents() query sys_refindex on recuid/ref_uid, which store the versioned uid. - resolveWorkspacesSetStageDependencies() and resolveWorkspacesDiscardDependencies() have always used $element->getId() directly. Publish was the odd one out. - transformDependentElementsToUseLiveId() was only a post-hoc re-keying of the result array to match the legacy command map's live-uid keys — both sides of the array_intersect_key were transformed identically, so dropping it is intersection-equivalent. -
core-ci voted on patch set 19 V +1 09/04/26, 14:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107890
-
Wouter Wolters voted on patch set 19 CR +1 V +1 09/07/26, 18:26
-
Georg Ringer voted on patch set 19 CR +1 V +1 09/07/26, 20:09
-
Simon Schaufelberger voted on patch set 19 CR +1 V +1 09/07/26, 21:16
-
Benni Mack uploaded patch set 20
CR +1V +109/08/26, 18:09 -
Wouter Wolters voted on patch set 20 CR +1 V +1 09/08/26, 18:10
-
core-ci voted on patch set 20 V +1 09/08/26, 18:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108110
-
Simon Schaufelberger voted on patch set 20 CR +1 V +1 09/08/26, 18:21
-
Georg Ringer voted on patch set 20 CR +1 V +1 09/30/26, 07:55
-
Benni Mack voted on patch set 20 CR +2 V +2 09/30/26, 08:06
-
Benni Mack merged patch set 21 09/30/26, 08:06