Review main Merged

89824[FEATURE] Add "publish" command to DataHandler

Benni Mack CR +2 V +2 Hard +561 −107 updated 09/30/26, 08:06

Commit message

This introduces a new "publish" command for workspaces that uses the
versioned record's UID as the primary identifier. The live record ID
and workspace ID are resolved automatically from t3ver_oid and t3ver_wsid.

Command structure:
$commandMap = [
    'pages' => [
        123 => [
            'publish' => [
                'comment' => 'Finally!',
            ]
        ]
    ]
];

This simplifies the publishing API compared to the legacy "version"
command with "swap" action, which required knowing the live record ID.

The "version" command will stay as is, and will be kept for now without
deprecation as it is used for setStage currently as well.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Wouter Wolters +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Wouter Wolters +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 13

Review log 3757

Show 1832 earlier messages
  1. Benni Mack uploaded patch set 1 06/23/25, 22:50

  2. Benni Mack marked it work in progress 06/23/25, 22:51

  3. core-ci voted on patch set 1 V -1 06/23/25, 23:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80673

  4. Benni Mack uploaded patch set 2 V -1 09/22/25, 15:13

  5. core-ci voted on patch set 2 V -1 09/22/25, 15:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85310

  6. Benni Mack commented on patch set 3 V -1 09/22/25, 19:50

    Published edit on patch set 2.
  7. Benni Mack commented on patch set 4 09/22/25, 19:50

    Published edit on patch set 3.
  8. core-ci voted on patch set 3 V -1 09/22/25, 20:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85341

  9. core-ci voted on patch set 4 V -1 09/22/25, 20:10 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85342

  10. Benni Mack uploaded patch set 5 V -1 09/24/25, 15:37

  11. core-ci voted on patch set 5 V +1 09/24/25, 15:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85458

  12. Benni Mack uploaded patch set 6 V +1 09/26/25, 13:13

  13. Benni Mack updated the commit message in patch set 7 09/26/25, 13:14

  14. core-ci voted on patch set 6 V -1 09/26/25, 13:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85608

  15. core-ci voted on patch set 7 V -1 09/26/25, 13:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85609

  16. Benni Mack uploaded patch set 8 V -1 09/26/25, 14:38

  17. core-ci voted on patch set 8 V -1 09/26/25, 14:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85614

  18. Benni Mack uploaded patch set 9 V -1 09/26/25, 16:34

  19. core-ci voted on patch set 9 V -1 09/26/25, 16:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85620

  20. Benni Mack uploaded patch set 10 V -1 09/29/25, 08:30

  21. core-ci voted on patch set 10 V -1 09/29/25, 08:40 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85689

  22. Benni Mack uploaded patch set 11 V -1 01/15/26, 21:55

  23. core-ci voted on patch set 11 V -1 01/15/26, 22:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93536

  24. Benni Mack uploaded patch set 12 V -1 01/15/26, 22:11

  25. Benni Mack updated the commit message in patch set 13 01/15/26, 22:11

  26. core-ci voted on patch set 12 V +1 01/15/26, 22:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93537

  27. core-ci voted on patch set 13 V +1 01/15/26, 22:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93538

  28. Benni Mack uploaded patch set 14 V +1 01/24/26, 19:48

  29. Benni Mack marked it ready for review 01/24/26, 19:50

  30. core-ci voted on patch set 14 V +1 01/24/26, 19:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94268

  31. Simon Schaufelberger commented on patch set 14 01/24/26, 20:18

    Feature-108649-IntroducePublishCommandForWorkspaces.rst:108

    please don't overuse php prefixes here as this is just a simple string and no php code.

    Feature-108649-IntroducePublishCommandForWorkspaces.rst:116

    please don't overuse php prefixes here as this is just a simple string and no php code.
  32. Benni Mack commented on patch set 15 V +1 01/25/26, 08:39

    Published edit on patch set 14.
  1. Benni Mack commented on patch set 15 01/25/26, 08:44

    Feature-108649-IntroducePublishCommandForWorkspaces.rst:108 Reply

    Done

    Feature-108649-IntroducePublishCommandForWorkspaces.rst:116 Reply

    Done
  2. core-ci voted on patch set 15 V +1 01/25/26, 08:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94296

  3. Simon Schaufelberger voted on patch set 15 CR +1 01/25/26, 09:38

  4. Anja Leichsenring voted on patch set 15 CR +1 V +1 02/01/26, 11:38

  5. Oliver Hader commented on patch set 15 02/10/26, 15:16

    CommandMap.php:83

    I'm not sure about this one... the elements here are used to resolve nested dependencies... using the version-id here without having to adjust any other underlying components (see `TYPO3\CMS\Workspaces\Dependency`) does not "feel" correct
  6. Anja Leichsenring uploaded patch set 16 CR +1 V +1 03/03/26, 08:13

  7. Anja Leichsenring commented on patch set 16 03/03/26, 08:14

    rebased only, Ollys remark is still in effect.
  8. core-ci voted on patch set 16 V +1 03/03/26, 08:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97157

  9. Simon Schaufelberger uploaded patch set 17 V +1 03/27/26, 09:05

  10. core-ci voted on patch set 17 V +1 03/27/26, 09:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98845

  11. Simon Schaufelberger rebased onto patch set 18 V +1 08/13/26, 10:22

  12. core-ci voted on patch set 18 V +1 08/13/26, 10:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106638

  13. Benni Mack uploaded patch set 19 V +1 09/04/26, 14:39

  14. Benni Mack commented on patch set 19 09/04/26, 14:40

    CommandMap.php:83 Reply

    The dependency layer is already version-id based:: - ElementEntity::$id is the versioned uid in both paths — the legacy version command passed swapWith (the version uid) as the constructor argument too. liveId is derived data, resolved in resolveWorkspaceState(). - getChildren()/getParents() query sys_refindex on recuid/ref_uid, which store the versioned uid. - resolveWorkspacesSetStageDependencies() and resolveWorkspacesDiscardDependencies() have always used $element->getId() directly. Publish was the odd one out. - transformDependentElementsToUseLiveId() was only a post-hoc re-keying of the result array to match the legacy command map's live-uid keys — both sides of the array_intersect_key were transformed identically, so dropping it is intersection-equivalent.
  15. core-ci voted on patch set 19 V +1 09/04/26, 14:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107890

  16. Wouter Wolters voted on patch set 19 CR +1 V +1 09/07/26, 18:26

  17. Georg Ringer voted on patch set 19 CR +1 V +1 09/07/26, 20:09

  18. Simon Schaufelberger voted on patch set 19 CR +1 V +1 09/07/26, 21:16

  19. Benni Mack uploaded patch set 20 CR +1 V +1 09/08/26, 18:09

  20. Wouter Wolters voted on patch set 20 CR +1 V +1 09/08/26, 18:10

  21. core-ci voted on patch set 20 V +1 09/08/26, 18:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108110

  22. Simon Schaufelberger voted on patch set 20 CR +1 V +1 09/08/26, 18:21

  23. Georg Ringer voted on patch set 20 CR +1 V +1 09/30/26, 07:55

  24. Benni Mack voted on patch set 20 CR +2 V +2 09/30/26, 08:06

  25. Benni Mack merged patch set 21 09/30/26, 08:06