Review main Merged

89826[TASK] Avoid unused WorkspaceService->getPagesWithVersionsInTable()

Christian Kuhn CR +2 V +2 Normal +1 −56 updated 06/24/25, 11:28

Commit message

The method is unused for a long time and removed. A single
functional test is removed along the way, the lower level
method fetchPagesWithVersionsInTable() is indirectly tested
by other tests covering public hasPageRecordVersions().

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 911

  1. Christian Kuhn uploaded patch set 1 06/23/25, 23:32

  2. core-ci voted on patch set 1 V +1 06/23/25, 23:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80675

  3. Christian Kuhn updated the commit message in patch set 2 V +1 06/24/25, 00:16

  4. Christian Kuhn commented on patch set 2 06/24/25, 00:18

    Let's have this in v13 as well since it may simplify a bugfix in this area: the class is @internal and a TER search revealed no results.
  5. core-ci voted on patch set 2 V +1 06/24/25, 00:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80677

  6. Benni Mack commented on patch set 2 06/24/25, 05:39

    They have been removed due to the removal of the hooks, and the usage of hasPageRecordVersions(). We should qualify however, what calls are really used in Page Tree and workspaces module to resolve the pages that have versioned items on it.
  7. Christian Kuhn commented on patch set 2 06/24/25, 09:48

    Reply

    Yeah. The only usage of hasPageRecordVersionsis nowadays PageTreeItemsHighlighter which is an event fired by TreeController. My goal is to inline the logic in there since it will simplify and potentially speed up the logic, sharpen the api and will obsolete the two cache properties. I can prepare that change, but i thought its more easy to follow if we do this one first. What do you prefer? The BE module 'list records grid' code needs different approaches to fetch affected workspace records.
  8. Benni Mack voted on patch set 2 CR +1 V +1 06/24/25, 09:53

  9. Stefan Bürk voted on patch set 2 CR +1 V +1 06/24/25, 10:24

  10. Christian Kuhn voted on patch set 2 CR +2 V +2 06/24/25, 11:28

  11. Christian Kuhn merged patch set 3 06/24/25, 11:28