Review main Merged

89827[TASK] Simplify a query in WorkspaceService

Christian Kuhn CR +2 V +2 Easy +2 −20 updated 06/24/25, 09:38

Commit message

It is enough to look for t3ver_wsid = X to find workspace
records in a given table. The additional clause looking
for t3ver_oid > 0 (modified, to-delete, moved) OR
t3ver_state = 1 (new) can be left out since it does not
reduce the result set any further.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Andreas Kienast +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 67

  1. Christian Kuhn uploaded patch set 1 06/23/25, 23:46

  2. core-ci voted on patch set 1 V +1 06/23/25, 23:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80676

  3. Benni Mack commented on patch set 1 CR +1 V +1 06/24/25, 05:36

    valid
  4. Andreas Kienast voted on patch set 1 CR +1 06/24/25, 06:28

  5. Stefan Bürk commented on patch set 1 CR +1 V +1 06/24/25, 07:54

    valid
  6. Christian Kuhn voted on patch set 1 CR +2 V +2 06/24/25, 09:38

  7. Christian Kuhn merged patch set 2 06/24/25, 09:38