89832[FEATURE] Allow usage of Symfony validators in Extbase
Commit message
Review
-
Code review CR +2 Done
- Garvin Hicking +2
- Torben Hansen +1
-
Verified V +2 Done
- Garvin Hicking +2
- Oliver Klee +1
- Torben Hansen +1
- core-ci +1 CI
Issues 1
Files 18
- Build/phpstan/phpstan-baseline.neon+1 −31
- typo3/sysext/core/Documentation/Changelog/14.0/Feature-106945-AllowUsageOfSymfonyValidatorsInExtbase.rst7new+103 −0
- typo3/sysext/extbase/Classes/Mvc/Controller/ActionController.php+9 −5
- typo3/sysext/extbase/Classes/Reflection/ClassSchema.php+19 −6
- typo3/sysext/extbase/Classes/Validation/Validator/AbstractCompositeValidator.php+6 −0
- typo3/sysext/extbase/Classes/Validation/Validator/AbstractGenericObjectValidator.php+2 −0
- typo3/sysext/extbase/Classes/Validation/Validator/ConjunctionValidator.php+0 −1
- typo3/sysext/extbase/Classes/Validation/Validator/ConstraintDecoratingValidator.phpnew+123 −0
- typo3/sysext/extbase/Classes/Validation/ValidatorResolver.php+10 −5
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/test_validators/Classes/Domain/Model/MixedSymfonyModel.phpnew+37 −0
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/test_validators/Classes/Domain/Model/SymfonyModel.phpnew+35 −0
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/test_validators/Resources/Private/Language/locallang.xlf+3 −0
- typo3/sysext/extbase/Tests/Functional/Mvc/Controller/ActionControllerTest.php+0 −2
- typo3/sysext/extbase/Tests/Functional/Validation/Validator/ConstraintDecoratingValidatorTest.phpnew+95 −0
- typo3/sysext/extbase/Tests/Functional/Validation/ValidatorResolverTest.php+151 −11
- typo3/sysext/extbase/composer.json+1 −0
- composer.json+1 −0
- composer.lock+103 −1
Review log 3248
Show 1523 earlier messages
-
Elias Häußler uploaded patch set 1 06/24/25, 08:58
-
Elias Häußler marked it work in progress 06/24/25, 08:58
-
core-ci voted on patch set 1 V -1 06/24/25, 09:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80704
-
Elias Häußler uploaded patch set 2
V -106/24/25, 09:22 -
core-ci voted on patch set 2 V -1 06/24/25, 09:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80710
-
Elias Häußler uploaded patch set 3
V -106/24/25, 09:48 -
Elias Häußler uploaded patch set 4 06/24/25, 09:49
-
core-ci voted on patch set 3 V -1 06/24/25, 09:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80717
-
core-ci voted on patch set 4 V +1 06/24/25, 10:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80718
-
Elias Häußler uploaded patch set 5
V +108/07/25, 18:54 -
core-ci voted on patch set 5 V +1 08/07/25, 19:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82874
-
Elias Häußler uploaded patch set 6
V +108/07/25, 19:08 -
Elias Häußler marked it ready for review 08/07/25, 19:08
-
core-ci voted on patch set 6 V +1 08/07/25, 19:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82879
-
Mathias Brodala commented on patch set 6 08/07/25, 19:32
Feature-106945-AllowUsageOfSymfonyValidatorsInExtbase.rst:57How about being "modern" here and have a public property instead? The getters/setters don't really add anything here. -
Elias Häußler uploaded patch set 7
V +108/07/25, 19:42 -
Elias Häußler commented on patch set 7 08/07/25, 19:56
Feature-106945-AllowUsageOfSymfonyValidatorsInExtbase.rst:56ReplyDoneFeature-106945-AllowUsageOfSymfonyValidatorsInExtbase.rst:57ReplyI'm not sure if we should mix too many "changes" here, since this could lead to confusion. Readers should focus on the new attributes; having additional changes from the current "established behavior" could make the actual change less understandable. But I don't have any hard feelings here :) -
core-ci voted on patch set 7 V +1 08/07/25, 19:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82893
-
Georg Ringer voted on patch set 7 CR +1 08/09/25, 09:31
-
Elias Häußler uploaded patch set 8
CR +1V +108/12/25, 07:43 -
core-ci voted on patch set 8 V +1 08/12/25, 07:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83177
-
Elias Häußler wrote 08/21/25, 06:55
Topic set to extbase -
Elias Häußler uploaded patch set 9
V +109/10/25, 18:55
-
core-ci voted on patch set 9 V +1 09/10/25, 19:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84799
-
Georg Ringer uploaded patch set 10
V +109/12/25, 09:19 -
core-ci voted on patch set 10 V +1 09/12/25, 09:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84903
-
Garvin Hicking uploaded patch set 11
V +109/19/25, 09:59 -
core-ci voted on patch set 11 V +1 09/19/25, 10:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85157
-
Garvin Hicking commented on patch set 11 09/24/25, 19:44
Feature-106945-AllowUsageOfSymfonyValidatorsInExtbase.rst:57ReplyI would agree. Current TYPO3 docs uses getters and setters for now, and I would like to have that on-par with the docs. getters/setters have the benfit of "gating" access and/or modifying values, and PHP 8 hooks there are not usable in TYPO3 yet (due to 8.2 min). I am quite sure we will revisit this once hooks will be more wide-spread and battle-tested. I'll resolve this and hope this is agreeable. -
Garvin Hicking uploaded patch set 12
V +109/24/25, 20:59 -
core-ci voted on patch set 12 V -1 09/24/25, 21:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85467
-
Garvin Hicking uploaded patch set 13
V -109/24/25, 21:18 -
core-ci voted on patch set 13 V +1 09/24/25, 21:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85468
-
Garvin Hicking commented on patch set 13 CR +1 V +1 09/24/25, 21:28
(I added some low-level tests to "proof" that validators work and have mix-and-match-ability for extbase+symfony next to each other)Feature-106945-AllowUsageOfSymfonyValidatorsInExtbase.rst:54This one (and country) requires "symfony/intl" which is not a dependency of ours. Should we use a different example, or also include symfony/intl as a dependency?! -
Elias Häußler uploaded patch set 14
CR +1V +109/26/25, 06:45 -
Elias Häußler uploaded patch set 15 09/26/25, 06:47
-
Elias Häußler commented on patch set 15 09/26/25, 06:48
Feature-106945-AllowUsageOfSymfonyValidatorsInExtbase.rst:54ReplyThanks for your hint. I exchanged both validators (BIC and Country) with other validators, which don't require additional Symfony components. -
core-ci voted on patch set 14 V +1 09/26/25, 06:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85569
-
core-ci voted on patch set 15 V +1 09/26/25, 06:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85570
-
Garvin Hicking voted on patch set 15 CR +1 V +1 09/26/25, 07:08
-
Oliver Klee voted on patch set 15 V +1 09/30/25, 14:55
-
Torben Hansen voted on patch set 15 CR +1 V +1 10/01/25, 16:24
-
Garvin Hicking uploaded patch set 16
CR +1V +110/01/25, 17:19 -
Torben Hansen voted on patch set 16 CR +1 V +1 10/01/25, 17:20
-
Oliver Klee voted on patch set 16 V +1 10/01/25, 17:23
-
core-ci voted on patch set 16 V +1 10/01/25, 17:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85832
-
Garvin Hicking commented on patch set 16 CR +2 V +2 10/01/25, 17:33
Thank you!! :-) -
Garvin Hicking merged patch set 17 10/01/25, 17:40
Feature-106945-AllowUsageOfSymfonyValidatorsInExtbase.rst:56