Review main Merged

89837[BUGFIX] Prevent type error in undefined felogin settings

Garvin Hicking CR +2 V +2 Easy +19 −3 updated 06/24/25, 18:24

Commit message

In case TypoScript/flexform settings for felogin are not
loaded, the checks for their values need to take possibly
unset array keys into account.

For this, null-coalescing is used to fallback to "null",
which then resolves to the falsy-elvis operator "?:" to
apply the actual default.

Checking "forgotLinkHashValidTime" is now additionally
secured to only contain numbers, so that "0" will properly
fall back to "12 hours".

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
    • Torben Hansen +1
    • Benni Mack +1
  • Verified V +2 Done
    • Garvin Hicking +2
    • Torben Hansen +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 68

  1. Garvin Hicking uploaded patch set 1 06/24/25, 09:48

  2. core-ci voted on patch set 1 V +1 06/24/25, 09:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80716

  3. Torben Hansen uploaded patch set 2 V +1 06/24/25, 15:38

  4. Torben Hansen voted on patch set 2 CR +1 V +1 06/24/25, 15:39

  5. core-ci voted on patch set 2 V +1 06/24/25, 15:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80767

  6. Benni Mack voted on patch set 2 CR +1 V +1 06/24/25, 15:59

  7. Garvin Hicking voted on patch set 2 CR +2 V +2 06/24/25, 18:08

  8. Garvin Hicking merged patch set 3 06/24/25, 18:24