Review 13.4 Merged

89838[TASK] Add more workspace related move and change tests

Christian Kuhn CR +2 V +2 Expert +1123 −0 updated 06/24/25, 10:55

Commit message

A lot of the "casual" or "simple" stuff is working with
workspaces nowadays. We however have various issues with
more complex chains like "first change a localized record
in workspaces, then move the default language record".

The patch adds a couple more tests to specify the current
state when such chains are done in workspaces.

There is one detail that seems to bite us in particular:
When a default language record that has localizations is
*modified* in workspaces, created overlays of localizations
point to the *live* record in l18n_parent/l10n_parent. But
when a default language record is *moved* in workspaces,
the localized overlays point to the *worspace* record in
l18n_parent/l10n_parent. This leads to issues when a
localized record is *first* modified and the default
language record is *then* moved, which changes the localized
record from modified to moved (which is correct), but does
not update l18n_parent/l10n_parent to the LIVE uid of the
default language record. We need to decide what is correct
here and have to adapt behavior with another patch.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 3

Files 31

Show 11 more files

Review log 45

  1. Christian Kuhn uploaded patch set 1 06/24/25, 09:58

  2. core-ci voted on patch set 1 V +1 06/24/25, 10:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80719

  3. Benni Mack voted on patch set 1 CR +1 V +1 06/24/25, 10:40

  4. Christian Kuhn voted on patch set 1 CR +2 V +2 06/24/25, 10:55

  5. Christian Kuhn merged patch set 2 06/24/25, 10:55