Review main Merged

89842[TASK] Simplify workspaces PageTreeItemsHighlighter

Christian Kuhn CR +2 V +2 Normal +64 −159 updated 06/24/25, 15:27

Commit message

Inline a simplified version of WorkspaceService
method hasPageRecordVersions() and a protected
helper method into PageTreeItemsHighlighter, a
consumer of an event dispatched by TreeController
(which renders the BE main page tree).

The methods are removed from WorkspaceService,
leading to a stateless service in v14.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 710

  1. Christian Kuhn uploaded patch set 1 06/24/25, 12:24

  2. core-ci voted on patch set 1 V -1 06/24/25, 12:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80723

  3. Christian Kuhn uploaded patch set 2 V -1 06/24/25, 12:44

  4. core-ci voted on patch set 2 V +1 06/24/25, 12:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80724

  5. Christian Kuhn uploaded patch set 3 V +1 06/24/25, 13:09

  6. core-ci voted on patch set 3 V +1 06/24/25, 13:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80726

  7. Benni Mack voted on patch set 3 CR +1 V +1 06/24/25, 13:25

  8. Stefan Bürk voted on patch set 3 CR +1 V +1 06/24/25, 14:14

  9. Christian Kuhn voted on patch set 3 CR +2 V +2 06/24/25, 15:26

  10. Christian Kuhn merged patch set 4 06/24/25, 15:27