89843[TASK] Move record preview logic to PreviewUriBuilder
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Andreas Nedbal +1
- Oli Bartsch +1
- Daniel Windloff +1
- Andreas Kienast +1
-
Verified V +2 Done
- Benni Mack +2
- Andreas Nedbal +1
- Oli Bartsch +1
- Daniel Windloff +1
- Andreas Kienast +1
- core-ci +1 CI
Issues 1
Files 6
- typo3/sysext/backend/Classes/ContextMenu/ItemProviders/PageProvider.php+0 −1
- typo3/sysext/backend/Classes/ContextMenu/ItemProviders/RecordProvider.php+6 −32
- typo3/sysext/backend/Classes/Controller/EditDocumentController.php+24 −216
- typo3/sysext/backend/Classes/RecordList/DatabaseRecordList.php5+18 −66
- typo3/sysext/backend/Classes/Routing/PreviewUriBuilder.php2+153 −12
- typo3/sysext/backend/Tests/Unit/Controller/EditDocumentControllerTest.php+0 −92
Review log 3248
Show 1223 earlier messages
-
Benni Mack uploaded patch set 1 06/24/25, 13:09
-
core-ci voted on patch set 1 V -1 06/24/25, 13:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80725
-
Benni Mack uploaded patch set 2
V -106/24/25, 13:27 -
core-ci voted on patch set 2 V -1 06/24/25, 13:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80727
-
Benni Mack uploaded patch set 3
V -106/24/25, 13:47 -
Benni Mack uploaded patch set 4 06/24/25, 13:52
-
Benni Mack uploaded patch set 5 06/24/25, 14:00
-
core-ci voted on patch set 3 V -1 06/24/25, 14:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80732
-
core-ci voted on patch set 4 V -1 06/24/25, 14:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80734
-
core-ci voted on patch set 5 V -1 06/24/25, 14:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80735
-
Benni Mack uploaded patch set 6
V -106/24/25, 15:53 -
core-ci voted on patch set 6 V -1 06/24/25, 16:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80769
-
Benni Mack uploaded patch set 7
V -106/24/25, 19:26 -
core-ci voted on patch set 7 V -1 06/24/25, 19:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80795
-
Oli Bartsch uploaded patch set 8
V -106/24/25, 19:38 -
core-ci voted on patch set 8 V +1 06/24/25, 19:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80797
-
Oli Bartsch commented on patch set 8 06/24/25, 19:47
-
Oli Bartsch uploaded patch set 9
V +106/24/25, 19:50 -
core-ci voted on patch set 9 V +1 06/24/25, 19:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80798
-
Oli Bartsch uploaded patch set 10
V +106/25/25, 19:22 -
core-ci voted on patch set 10 V -1 06/25/25, 19:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80901
-
Oli Bartsch uploaded patch set 11
V -106/25/25, 19:53 -
core-ci voted on patch set 11 V -1 06/25/25, 20:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80909
-
Oli Bartsch uploaded patch set 12
V -106/25/25, 20:22 -
core-ci voted on patch set 12 V +1 06/25/25, 20:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80914
-
Oli Bartsch uploaded patch set 13
V +106/26/25, 08:54 -
Oli Bartsch commented on patch set 13 06/26/25, 08:55
DatabaseRecordList.php:1584ReplyActually evaluation of this option at this place made no sense at all. -
core-ci voted on patch set 13 V -1 06/26/25, 09:01 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80966
-
Oli Bartsch uploaded patch set 14
V -106/26/25, 09:09 -
Benni Mack commented on patch set 13 06/26/25, 09:12
PreviewUriBuilder.php:106can you check if we can hand in $record as int|array to have the full record already available if possible (e.g. Context Menu) -
core-ci voted on patch set 14 V +1 06/26/25, 09:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80967
-
Oli Bartsch uploaded patch set 15
V +106/26/25, 09:24 -
Oli Bartsch commented on patch set 15 06/26/25, 09:24
PreviewUriBuilder.php:106ReplyGood idea. -
core-ci voted on patch set 15 V +1 06/26/25, 09:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80968
-
Oli Bartsch voted on patch set 15 CR +1 V +1 06/26/25, 09:34
-
Daniel Windloff commented on patch set 15 06/26/25, 10:41
Thanks for bringing this up again :) -
Andreas Nedbal voted on patch set 15 CR +1 V +1 06/26/25, 12:51
-
Daniel Windloff commented on patch set 15 06/26/25, 12:58
DatabaseRecordList.php:1103The row may not have all columns, that are used in the preview configuration: Example config for a styleguide element: TCEMAIN.preview { tx_styleguide_elements_basic { previewPageId = 3643 useDefaultLanguageRecord = 0 fieldToParameterMap { uid =tx_styleguide_elements_basic[showUid] input_22=tx_styleguide_elements_basic[input_22] } additionalGetParameters { tx_myext_pi1.special = HELLO } } } Result: input_22 is only used, if the column is selected, otherwise it's empty -
Daniel Windloff commented on patch set 15 06/26/25, 13:14
DatabaseRecordList.php:1103Reply```suggestion $row['uid'], ``` -
Oli Bartsch uploaded patch set 16
CR +1V +106/26/25, 13:33 -
Oli Bartsch commented on patch set 16 06/26/25, 13:33
DatabaseRecordList.php:1103ReplyYes, thanks! -
core-ci voted on patch set 16 V +1 06/26/25, 13:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80987
-
Daniel Windloff voted on patch set 16 CR +1 V +1 06/26/25, 13:42
-
Andreas Nedbal voted on patch set 16 CR +1 V +1 06/26/25, 13:43
-
Oli Bartsch voted on patch set 16 CR +1 V +1 06/26/25, 13:43
-
Andreas Kienast voted on patch set 16 CR +1 V +1 06/26/25, 14:44
-
Benni Mack voted on patch set 16 CR +2 V +2 06/26/25, 15:09
-
Benni Mack merged patch set 17 06/26/25, 15:09
DatabaseRecordList.php:1584