Review main Merged

89843[TASK] Move record preview logic to PreviewUriBuilder

Benni Mack CR +2 V +2 Hard +201 −419 updated 06/26/25, 15:09

Commit message

All of the code in `EditDocumentController` is
moved into the PreviewUriBuilder. Therefore,
the `PreviewUriBuilder` does now provide the
logic of creating preview uris for all kind
of records globally.

This means, components like the list view,
the context menu do now properly provide the
preview option for custom records.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Andreas Nedbal +1
    • Oli Bartsch +1
    • Daniel Windloff +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Benni Mack +2
    • Andreas Nedbal +1
    • Oli Bartsch +1
    • Daniel Windloff +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 6

Review log 3248

Show 1223 earlier messages
  1. Benni Mack uploaded patch set 1 06/24/25, 13:09

  2. core-ci voted on patch set 1 V -1 06/24/25, 13:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80725

  3. Benni Mack uploaded patch set 2 V -1 06/24/25, 13:27

  4. core-ci voted on patch set 2 V -1 06/24/25, 13:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80727

  5. Benni Mack uploaded patch set 3 V -1 06/24/25, 13:47

  6. Benni Mack uploaded patch set 4 06/24/25, 13:52

  7. Benni Mack uploaded patch set 5 06/24/25, 14:00

  8. core-ci voted on patch set 3 V -1 06/24/25, 14:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80732

  9. core-ci voted on patch set 4 V -1 06/24/25, 14:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80734

  10. core-ci voted on patch set 5 V -1 06/24/25, 14:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80735

  11. Benni Mack uploaded patch set 6 V -1 06/24/25, 15:53

  12. core-ci voted on patch set 6 V -1 06/24/25, 16:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80769

  13. Benni Mack uploaded patch set 7 V -1 06/24/25, 19:26

  14. core-ci voted on patch set 7 V -1 06/24/25, 19:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80795

  15. Oli Bartsch uploaded patch set 8 V -1 06/24/25, 19:38

  16. core-ci voted on patch set 8 V +1 06/24/25, 19:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80797

  17. Oli Bartsch commented on patch set 8 06/24/25, 19:47

    DatabaseRecordList.php:1584

    this now silently removes mod.web_list.noViewWithDokTypes
  18. Oli Bartsch uploaded patch set 9 V +1 06/24/25, 19:50

  19. core-ci voted on patch set 9 V +1 06/24/25, 19:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80798

  20. Oli Bartsch uploaded patch set 10 V +1 06/25/25, 19:22

  21. core-ci voted on patch set 10 V -1 06/25/25, 19:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80901

  22. Oli Bartsch uploaded patch set 11 V -1 06/25/25, 19:53

  23. core-ci voted on patch set 11 V -1 06/25/25, 20:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80909

  1. Oli Bartsch uploaded patch set 12 V -1 06/25/25, 20:22

  2. core-ci voted on patch set 12 V +1 06/25/25, 20:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80914

  3. Oli Bartsch uploaded patch set 13 V +1 06/26/25, 08:54

  4. Oli Bartsch commented on patch set 13 06/26/25, 08:55

    DatabaseRecordList.php:1584 Reply

    Actually evaluation of this option at this place made no sense at all.
  5. core-ci voted on patch set 13 V -1 06/26/25, 09:01 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80966

  6. Oli Bartsch uploaded patch set 14 V -1 06/26/25, 09:09

  7. Benni Mack commented on patch set 13 06/26/25, 09:12

    PreviewUriBuilder.php:106

    can you check if we can hand in $record as int|array to have the full record already available if possible (e.g. Context Menu)
  8. core-ci voted on patch set 14 V +1 06/26/25, 09:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80967

  9. Oli Bartsch uploaded patch set 15 V +1 06/26/25, 09:24

  10. Oli Bartsch commented on patch set 15 06/26/25, 09:24

    PreviewUriBuilder.php:106 Reply

    Good idea.
  11. core-ci voted on patch set 15 V +1 06/26/25, 09:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80968

  12. Oli Bartsch voted on patch set 15 CR +1 V +1 06/26/25, 09:34

  13. Daniel Windloff commented on patch set 15 06/26/25, 10:41

    Thanks for bringing this up again :)
  14. Andreas Nedbal voted on patch set 15 CR +1 V +1 06/26/25, 12:51

  15. Daniel Windloff commented on patch set 15 06/26/25, 12:58

    DatabaseRecordList.php:1103

    The row may not have all columns, that are used in the preview configuration: Example config for a styleguide element: TCEMAIN.preview { tx_styleguide_elements_basic { previewPageId = 3643 useDefaultLanguageRecord = 0 fieldToParameterMap { uid =tx_styleguide_elements_basic[showUid] input_22=tx_styleguide_elements_basic[input_22] } additionalGetParameters { tx_myext_pi1.special = HELLO } } } Result: input_22 is only used, if the column is selected, otherwise it's empty
  16. Daniel Windloff commented on patch set 15 06/26/25, 13:14

    DatabaseRecordList.php:1103 Reply

    ```suggestion $row['uid'], ```
  17. Oli Bartsch uploaded patch set 16 CR +1 V +1 06/26/25, 13:33

  18. Oli Bartsch commented on patch set 16 06/26/25, 13:33

    DatabaseRecordList.php:1103 Reply

    Yes, thanks!
  19. core-ci voted on patch set 16 V +1 06/26/25, 13:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80987

  20. Daniel Windloff voted on patch set 16 CR +1 V +1 06/26/25, 13:42

  21. Andreas Nedbal voted on patch set 16 CR +1 V +1 06/26/25, 13:43

  22. Oli Bartsch voted on patch set 16 CR +1 V +1 06/26/25, 13:43

  23. Andreas Kienast voted on patch set 16 CR +1 V +1 06/26/25, 14:44

  24. Benni Mack voted on patch set 16 CR +2 V +2 06/26/25, 15:09

  25. Benni Mack merged patch set 17 06/26/25, 15:09