Review 13.4 Merged

89849[TASK] Simplify workspaces PageTreeItemsHighlighter

Christian Kuhn CR +2 V +2 Normal +60 −160 updated 06/24/25, 15:27

Commit message

Inline a simplified version of WorkspaceService
method hasPageRecordVersions() and a protected
helper method into PageTreeItemsHighlighter, a
consumer of an event dispatched by TreeController
(which renders the BE main page tree).

The methods are removed from WorkspaceService,
leading to a stateless service in v14.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
  • Verified V +2 Done
    • Christian Kuhn +2
    • core-ci +1 CI

Issues 1

Files 4

Review log 46

  1. Christian Kuhn uploaded patch set 1 06/24/25, 14:29

  2. Christian Kuhn uploaded patch set 2 06/24/25, 14:48

  3. core-ci voted on patch set 1 V -1 06/24/25, 15:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80746

  4. core-ci voted on patch set 2 V +1 06/24/25, 15:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80754

  5. Christian Kuhn voted on patch set 2 CR +2 V +2 06/24/25, 15:27

  6. Christian Kuhn merged patch set 3 06/24/25, 15:27