89854[TASK] Extract workspace internal table hook code
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Stefan Bürk +1
- Benni Mack +1
-
Verified V +2 Done
- Christian Kuhn +2
- Stefan Bürk +1
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 5
- typo3/sysext/core/Classes/DataHandling/DataHandler.php+12 −9
- typo3/sysext/workspaces/Classes/Controller/WorkspacesAjaxController.php+5 −0
- typo3/sysext/workspaces/Classes/Hook/DataHandlerHook.php+0 −124
- typo3/sysext/workspaces/Classes/Hook/DataHandlerInternalWorkspaceTablesHook.php2new+170 −0
- typo3/sysext/workspaces/ext_localconf.php+4 −1
Review log 1419
-
Christian Kuhn uploaded patch set 1 06/24/25, 16:03
-
core-ci voted on patch set 1 V +1 06/24/25, 16:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80771
-
Christian Kuhn uploaded patch set 2
V +106/24/25, 17:01 -
core-ci voted on patch set 2 V +1 06/24/25, 17:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80778
-
Christian Kuhn uploaded patch set 3
V +106/24/25, 18:27 -
Christian Kuhn updated the commit message in patch set 4 06/24/25, 18:28
-
core-ci voted on patch set 4 V +1 06/24/25, 18:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80790
-
core-ci voted on patch set 3 V +1 06/24/25, 18:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80789
-
Benni Mack commented on patch set 4 CR +1 V +1 06/24/25, 18:48
I think it would be good to have this in v13 as well -
Christian Kuhn updated the commit message in patch set 5
CR +1V +106/24/25, 22:00 -
Christian Kuhn commented on patch set 5 06/24/25, 22:01
Reply
alright. slightly breaking but doable. adapted commit msg. -
core-ci voted on patch set 5 V +1 06/24/25, 22:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80808
-
Stefan Bürk voted on patch set 5 CR +1 06/24/25, 23:23
-
Stefan Bürk voted on patch set 5 V +1 06/24/25, 23:29
-
Benni Mack voted on patch set 5 CR +1 V +1 06/25/25, 06:03
-
Christian Kuhn voted on patch set 5 CR +2 V +2 06/25/25, 12:02
-
Christian Kuhn merged patch set 6 06/25/25, 12:02
-
Andreas Kienast commented on patch set 6 06/25/25, 15:26
DataHandlerInternalWorkspaceTablesHook.php:1Was `declare(strict_types=1)` forgotten or left out on purpose? -
Christian Kuhn commented on patch set 6 07/07/25, 21:51
DataHandlerInternalWorkspaceTablesHook.php:1Replygood catch. forgotten. will add as drive-by with another change.