Review main Merged

89854[TASK] Extract workspace internal table hook code

Christian Kuhn CR +2 V +2 Hard +191 −134 updated 07/07/25, 21:51

Commit message

The main ext:workspaces DataHandlerHook is shrinking
for a while already: We're integrating more and more
into DataHandler directly to enable streamlining and
refactoring. One of the next steps will be looking at
the remaining "publish" and "setStage" code to see
what could be moved to DataHandler as well.

In addition to this, this patch extracts two other
standalone parts of DataHandlerHook to an isolated
class DataHandlerInternalWorkspaceTablesHook: It
handles things that have to be done when
sys_workspace_stage and sys_workspace rows are
editited in the backend. The handling when deleting
a sys_workspace_stage is also slightly improved by
adding a log entry stating affected record counts.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 1419

  1. Christian Kuhn uploaded patch set 1 06/24/25, 16:03

  2. core-ci voted on patch set 1 V +1 06/24/25, 16:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80771

  3. Christian Kuhn uploaded patch set 2 V +1 06/24/25, 17:01

  4. core-ci voted on patch set 2 V +1 06/24/25, 17:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80778

  5. Christian Kuhn uploaded patch set 3 V +1 06/24/25, 18:27

  6. Christian Kuhn updated the commit message in patch set 4 06/24/25, 18:28

  7. core-ci voted on patch set 4 V +1 06/24/25, 18:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80790

  8. core-ci voted on patch set 3 V +1 06/24/25, 18:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80789

  9. Benni Mack commented on patch set 4 CR +1 V +1 06/24/25, 18:48

    I think it would be good to have this in v13 as well
  10. Christian Kuhn updated the commit message in patch set 5 CR +1 V +1 06/24/25, 22:00

  11. Christian Kuhn commented on patch set 5 06/24/25, 22:01

    Reply

    alright. slightly breaking but doable. adapted commit msg.
  12. core-ci voted on patch set 5 V +1 06/24/25, 22:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80808

  13. Stefan Bürk voted on patch set 5 CR +1 06/24/25, 23:23

  14. Stefan Bürk voted on patch set 5 V +1 06/24/25, 23:29

  15. Benni Mack voted on patch set 5 CR +1 V +1 06/25/25, 06:03

  16. Christian Kuhn voted on patch set 5 CR +2 V +2 06/25/25, 12:02

  17. Christian Kuhn merged patch set 6 06/25/25, 12:02

  18. Andreas Kienast commented on patch set 6 06/25/25, 15:26

    DataHandlerInternalWorkspaceTablesHook.php:1

    Was `declare(strict_types=1)` forgotten or left out on purpose?
  19. Christian Kuhn commented on patch set 6 07/07/25, 21:51

    DataHandlerInternalWorkspaceTablesHook.php:1 Reply

    good catch. forgotten. will add as drive-by with another change.