Review 13.4 Merged

89855[TASK] Simplify record objects in Workspaces

Benni Mack CR +2 V +2 Hard +93 −219 updated 06/24/25, 18:48

Commit message

Workspaces includes a Record pattern that
has similarities to a Entity with a small
ActiveRecord style.

This was maybe meant for something bigger,
but is now removed, as it serves no purpose in
workspaces.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • core-ci +1 CI

Issues 1

Files 5

Review log 69

  1. Benni Mack commented on patch set 1 06/24/25, 17:52

    Cherry Picked from branch main. The following files contain Git conflicts: * typo3/sysext/workspaces/Tests/Unit/Domain/Model/WorkspaceRecordTest.php
  2. Benni Mack commented on patch set 2 06/24/25, 17:53

    Published edit on patch set 1.
  3. Benni Mack marked it ready for review 06/24/25, 17:53

  4. core-ci voted on patch set 1 V -1 06/24/25, 18:01 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80779

  5. core-ci voted on patch set 2 V -1 06/24/25, 18:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80780

  6. Christian Kuhn uploaded patch set 3 V -1 06/24/25, 18:33

  7. core-ci voted on patch set 3 V +1 06/24/25, 18:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80791

  8. Benni Mack voted on patch set 3 CR +2 V +2 06/24/25, 18:47

  9. Benni Mack merged patch set 4 06/24/25, 18:48