Review main Merged

89860[TASK] Remove internal flag from Schema API

Benni Mack CR +2 V +2 Normal +29 −144 updated 07/03/25, 14:34

Commit message

Schema API has been rolled out slowly into many areas
of TYPO3 Core and has been proven to cover most
scenarios.

Missing places:

1. FormEngine due to its nature of modifying TCA on-the-go
   and its use of using $GLOBALS[TCA] from Site Configuration.

2. Icon API as it is tightly bound to FormEngine and
   cannot migrated yet.

For this reason, the internal flag is removed in v14.0
and Schema API is the official way to access information
from $GLOBALS[TCA] ("Read" functionality) for the TYPO3 Core
API.

However, some areas from Schema API are still marked
as internal, as they might seem redundant and could get
removed.

The SchemaInterface class will also receive further adapations
once its impact is clearer.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Benjamin Franzke +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Benjamin Franzke +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 55

Show 35 more files

Review log 1419

  1. Benni Mack uploaded patch set 1 06/24/25, 20:32

  2. core-ci voted on patch set 1 V -1 06/24/25, 20:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80806

  3. Benni Mack updated the commit message in patch set 2 V -1 06/25/25, 09:44

  4. core-ci voted on patch set 2 V -1 06/25/25, 09:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80833

  5. Benni Mack rebased onto patch set 3 V -1 06/25/25, 21:08

  6. core-ci voted on patch set 3 V +1 06/25/25, 21:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80928

  7. Benni Mack updated the commit message in patch set 4 V +1 06/28/25, 07:23

  8. core-ci voted on patch set 4 V +1 06/28/25, 07:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81093

  9. Benjamin Franzke commented on patch set 4 07/01/25, 11:29

    I think this will mean that we need some sort of a `TcaSchemaContainer` which can contain a list/map of TcaSchema instances. For that reason I'm a bit afraid that calling "TcaSchemaFactory" an API is to early, since I feel like more methods should accept `TcaSchema` or `TcaSchemaContainer` instead of tablenames or arrays of tablenames which are then used to lookup a schema via the global schema factory instance which we actually use like a registry and not like a factory. Maybe we should even rename the TcaSchemaFactory to "TcaSchemaRegistry" – but even then we still need a TcaSchemaContainer for the "processed TCA" case. Thinking about it again and again and the obstacles involved we should probably try to phase-out the concept of a runtime "processed" TCA.
  10. Benjamin Franzke commented on patch set 4 07/03/25, 11:23

    Why does the patch change so many code places, besides removing `@internal`? They looks like general adaptions (or an inadvertent rebase-squash?) which we should also backport to v13 (to make later bugfixes easier) and having these separate would ease a review.

    Reply

    not relevant right now. resolving.
  11. Benni Mack rebased onto patch set 5 V +1 07/03/25, 11:41

  12. core-ci voted on patch set 5 V +1 07/03/25, 11:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81279

  13. Benni Mack commented on patch set 5 07/03/25, 12:19

    Reply

    If I do single patches for each of these things in the Schema API area, getting them in takes even longer - at least that is my verdict in the past 3 months. I've started with this finalizing work in March 2025 for the Schema API, and getting reviews in general for such changes just takes a long time, because people are busy with their own work and patches, having their own priorities. More patches = larger work areas take even longer to continue. Working on core changes in general is very frustrating currently as feedback is very little and mostly if I ping people directly _and_ they have time for this. The fact that it took 9 days for somebody to give feedback on a rather "easy to review" patch takes away my motivation to push such a topic further - meaning: The lack of activity makes me sad - and I can imagine how others feel if they push a bugfix. So: Thanks for asking the question and giving feedback. We could label these changes as "drive-by" changes, or "discussion points" for the API design. However, finding people for constructively discussing API design for larger Core changes is like searching for water in the desert. I pushed early Schema API drafts (two variants) for v11 to be included - that was 2021 IIRC - feedback was very little. If the drive-by changes won't make it in v13, I don't care anymore. If we leave out the drive-by changes completely, fine be me as well. Core work is just very exhausting these days.
  14. Benjamin Franzke commented on patch set 5 07/03/25, 12:51

    Reply

    Alright, understood. Will try to review as-is.
  15. Benjamin Franzke voted on patch set 5 CR +1 V +1 07/03/25, 13:25

  16. Stefan Bürk voted on patch set 5 CR +1 V +1 07/03/25, 13:37

  17. Oli Bartsch commented on patch set 5 V -1 07/03/25, 14:10

    Unresolved

    Reviewing
  18. Oli Bartsch voted on patch set 5 CR +2 V +2 07/03/25, 14:34

  19. Oli Bartsch merged patch set 6 07/03/25, 14:34