89860[TASK] Remove internal flag from Schema API
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Benjamin Franzke +1
- Stefan Bürk +1
-
Verified V +2 Done
- Oli Bartsch +2
- Benjamin Franzke +1
- Stefan Bürk +1
- core-ci +1 CI
Issues 1
Files 55
- typo3/sysext/backend/Classes/RecordList/DatabaseRecordList.php+3 −3
- typo3/sysext/backend/Classes/View/BackendLayout/Grid/GridColumnItem.php+2 −3
- typo3/sysext/core/Classes/DataHandling/Localization/DataMapProcessor.php+1 −1
- typo3/sysext/core/Classes/Hooks/TcaItemsProcessorFunctions.php+1 −1
- typo3/sysext/core/Classes/Schema/Capability/FieldCapability.php+0 −2
- typo3/sysext/core/Classes/Schema/Capability/LabelCapability.php+0 −2
- typo3/sysext/core/Classes/Schema/Capability/LanguageAwareSchemaCapability.php+0 −2
- typo3/sysext/core/Classes/Schema/Capability/RootLevelCapability.php+0 −2
- typo3/sysext/core/Classes/Schema/Capability/ScalarCapability.php+0 −2
- typo3/sysext/core/Classes/Schema/Capability/SchemaCapabilityInterface.php+0 −2
- typo3/sysext/core/Classes/Schema/Capability/TcaSchemaCapability.php+0 −2
- typo3/sysext/core/Classes/Schema/Field/CategoryFieldType.php+0 −3
- typo3/sysext/core/Classes/Schema/Field/CheckboxFieldType.php+0 −3
- typo3/sysext/core/Classes/Schema/Field/ColorFieldType.php+0 −3
- typo3/sysext/core/Classes/Schema/Field/DateTimeFieldType.php+0 −3
- typo3/sysext/core/Classes/Schema/Field/EmailFieldType.php+0 −3
- typo3/sysext/core/Classes/Schema/Field/FieldCollection.php+0 −3
- typo3/sysext/core/Classes/Schema/Field/FieldTranslationBehaviour.php+0 −2
- typo3/sysext/core/Classes/Schema/Field/FieldTypeInterface.php+0 −2
- typo3/sysext/core/Classes/Schema/Field/FileFieldType.php+0 −2
Show 35 more files
- typo3/sysext/core/Classes/Schema/Field/FlexFormFieldType.php+0 −3
- typo3/sysext/core/Classes/Schema/Field/FolderFieldType.php+0 −3
- typo3/sysext/core/Classes/Schema/Field/GroupFieldType.php+0 −3
- typo3/sysext/core/Classes/Schema/Field/ImageManipulationFieldType.php+0 −3
- typo3/sysext/core/Classes/Schema/Field/InlineFieldType.php+1 −3
- typo3/sysext/core/Classes/Schema/Field/InputFieldType.php+0 −3
- typo3/sysext/core/Classes/Schema/Field/JsonFieldType.php+0 −3
- typo3/sysext/core/Classes/Schema/Field/LanguageFieldType.php+0 −3
- typo3/sysext/core/Classes/Schema/Field/LinkFieldType.php+0 −3
- typo3/sysext/core/Classes/Schema/Field/NoneFieldType.php+0 −3
- typo3/sysext/core/Classes/Schema/Field/NumberFieldType.php+0 −3
- typo3/sysext/core/Classes/Schema/Field/PassthroughFieldType.php+0 −3
- typo3/sysext/core/Classes/Schema/Field/PasswordFieldType.php+0 −3
- typo3/sysext/core/Classes/Schema/Field/RadioFieldType.php+0 −3
- typo3/sysext/core/Classes/Schema/Field/RelationalFieldTypeInterface.php+0 −2
- typo3/sysext/core/Classes/Schema/Field/SelectRelationFieldType.php+0 −2
- typo3/sysext/core/Classes/Schema/Field/SlugFieldType.php+0 −3
- typo3/sysext/core/Classes/Schema/Field/StaticSelectFieldType.php+0 −2
- typo3/sysext/core/Classes/Schema/Field/SystemInternalFieldType.php+1 −1
- typo3/sysext/core/Classes/Schema/Field/TextFieldType.php+0 −3
- typo3/sysext/core/Classes/Schema/Field/UserFieldType.php+0 −3
- typo3/sysext/core/Classes/Schema/Field/UuidFieldType.php+0 −3
- typo3/sysext/core/Classes/Schema/Struct/FlexSheet.php+0 −2
- typo3/sysext/core/Classes/Schema/ActiveRelation.php+0 −2
- typo3/sysext/core/Classes/Schema/FieldFormat.php+0 −3
- typo3/sysext/core/Classes/Schema/FieldTypeFactory.php+0 −2
- typo3/sysext/core/Classes/Schema/FlexFormSchema.php+14 −3
- typo3/sysext/core/Classes/Schema/FlexFormSchemaFactory.php+0 −2
- typo3/sysext/core/Classes/Schema/PassiveRelation.php+0 −2
- typo3/sysext/core/Classes/Schema/RelationshipType.php+0 −3
- typo3/sysext/core/Classes/Schema/SchemaCollection.php+0 −3
- typo3/sysext/core/Classes/Schema/SchemaInterface.php+5 −2
- typo3/sysext/core/Classes/Schema/SchemaTypeInformation.php+0 −2
- typo3/sysext/core/Classes/Schema/TcaSchema.php+1 −9
- typo3/sysext/core/Classes/Schema/TcaSchemaFactory.php+0 −2
Review log 1419
-
Benni Mack uploaded patch set 1 06/24/25, 20:32
-
core-ci voted on patch set 1 V -1 06/24/25, 20:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80806
-
Benni Mack updated the commit message in patch set 2
V -106/25/25, 09:44 -
core-ci voted on patch set 2 V -1 06/25/25, 09:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80833
-
Benni Mack rebased onto patch set 3
V -106/25/25, 21:08 -
core-ci voted on patch set 3 V +1 06/25/25, 21:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80928
-
Benni Mack updated the commit message in patch set 4
V +106/28/25, 07:23 -
core-ci voted on patch set 4 V +1 06/28/25, 07:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81093
-
Benjamin Franzke commented on patch set 4 07/01/25, 11:29
I think this will mean that we need some sort of a `TcaSchemaContainer` which can contain a list/map of TcaSchema instances. For that reason I'm a bit afraid that calling "TcaSchemaFactory" an API is to early, since I feel like more methods should accept `TcaSchema` or `TcaSchemaContainer` instead of tablenames or arrays of tablenames which are then used to lookup a schema via the global schema factory instance which we actually use like a registry and not like a factory. Maybe we should even rename the TcaSchemaFactory to "TcaSchemaRegistry" – but even then we still need a TcaSchemaContainer for the "processed TCA" case. Thinking about it again and again and the obstacles involved we should probably try to phase-out the concept of a runtime "processed" TCA. -
Benjamin Franzke commented on patch set 4 07/03/25, 11:23
Why does the patch change so many code places, besides removing `@internal`? They looks like general adaptions (or an inadvertent rebase-squash?) which we should also backport to v13 (to make later bugfixes easier) and having these separate would ease a review.Reply
not relevant right now. resolving. -
Benni Mack rebased onto patch set 5
V +107/03/25, 11:41 -
core-ci voted on patch set 5 V +1 07/03/25, 11:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81279
-
Benni Mack commented on patch set 5 07/03/25, 12:19
Reply
If I do single patches for each of these things in the Schema API area, getting them in takes even longer - at least that is my verdict in the past 3 months. I've started with this finalizing work in March 2025 for the Schema API, and getting reviews in general for such changes just takes a long time, because people are busy with their own work and patches, having their own priorities. More patches = larger work areas take even longer to continue. Working on core changes in general is very frustrating currently as feedback is very little and mostly if I ping people directly _and_ they have time for this. The fact that it took 9 days for somebody to give feedback on a rather "easy to review" patch takes away my motivation to push such a topic further - meaning: The lack of activity makes me sad - and I can imagine how others feel if they push a bugfix. So: Thanks for asking the question and giving feedback. We could label these changes as "drive-by" changes, or "discussion points" for the API design. However, finding people for constructively discussing API design for larger Core changes is like searching for water in the desert. I pushed early Schema API drafts (two variants) for v11 to be included - that was 2021 IIRC - feedback was very little. If the drive-by changes won't make it in v13, I don't care anymore. If we leave out the drive-by changes completely, fine be me as well. Core work is just very exhausting these days. -
Benjamin Franzke commented on patch set 5 07/03/25, 12:51
Reply
Alright, understood. Will try to review as-is. -
Benjamin Franzke voted on patch set 5 CR +1 V +1 07/03/25, 13:25
-
Stefan Bürk voted on patch set 5 CR +1 V +1 07/03/25, 13:37
-
Oli Bartsch commented on patch set 5 V -1 07/03/25, 14:10
Unresolved
Reviewing -
Oli Bartsch voted on patch set 5 CR +2 V +2 07/03/25, 14:34
-
Oli Bartsch merged patch set 6 07/03/25, 14:34