Review main Merged Breaking

89862[!!!][TASK] Set default light/dark context awareness for CKEditor

Garvin Hicking CR +2 V +2 Normal +75 −32 updated 06/30/25, 15:42

Commit message

With #105640, context awareness for CKEditor RTE was introduced, but
not enabled by default to not break existing customizations/enhancements
of the editor interface.

The TYPO3 Core default stylesheet [1] is now adapted to enable the
context awareness by default. Prior white backgrounds are now shown
as either dark or light backgrounds, depending on the editor's
preference. Color assignments of "links" are slightly adjusted,
Other existing color assignments (broken links, blockquotes) are fine
in both modes.

Please note that the display of RTE contents in the frontend is
unaffected.

[1] EXT:rte_ckeditor/Resources/Public/Css/contents.css

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
    • Andreas Nedbal +1
    • Benjamin Kott +1
  • Verified V +2 Done
    • Garvin Hicking +2
    • Andreas Nedbal +1
    • Benjamin Kott +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 1316

  1. Garvin Hicking uploaded patch set 1 06/25/25, 07:55

  2. core-ci voted on patch set 1 V +1 06/25/25, 08:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80826

  3. Garvin Hicking uploaded patch set 2 V +1 06/26/25, 08:01

  4. Garvin Hicking uploaded patch set 3 06/26/25, 08:15

  5. core-ci voted on patch set 3 V +1 06/26/25, 08:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80954

  6. Benjamin Franzke commented on patch set 3 06/26/25, 08:41

    contents.css:5

    I think we should define a default color (also background) for both modes via `light-dark()`.
  7. Benjamin Kott commented on patch set 3 CR -1 06/27/25, 09:07

    on it
  8. Benjamin Kott uploaded patch set 4 CR -1 V +1 06/27/25, 11:20

  9. Benjamin Kott commented on patch set 4 06/27/25, 11:20

    contents.css:5 Reply

    Done
  10. core-ci voted on patch set 4 V +1 06/27/25, 11:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81077

  11. Benjamin Kott voted on patch set 4 CR +1 V +1 06/28/25, 02:42

  12. Simon Schaufelberger commented on patch set 4 06/30/25, 07:58

    is this file not generated from a scss file?
  13. Garvin Hicking commented on patch set 4 06/30/25, 15:27

    Reply

    No, due to its simplicity I guess, this one is the cssdroid you're looking for :)
  14. Andreas Nedbal voted on patch set 4 CR +1 V +1 06/30/25, 15:31

  15. Garvin Hicking voted on patch set 4 CR +2 V +2 06/30/25, 15:42

  16. Garvin Hicking merged patch set 5 06/30/25, 15:42