Review 13.4 Merged

89873[TASK] Extract workspace internal table hook code

Christian Kuhn CR +2 V +2 Hard +175 −126 updated 06/25/25, 12:02

Commit message

The main ext:workspaces DataHandlerHook is shrinking
for a while already: We're integrating more and more
into DataHandler directly to enable streamlining and
refactoring. One of the next steps will be looking at
the remaining "publish" and "setStage" code to see
what could be moved to DataHandler as well.

In addition to this, this patch extracts two other
standalone parts of DataHandlerHook to an isolated
class DataHandlerInternalWorkspaceTablesHook: It
handles things that have to be done when
sys_workspace_stage and sys_workspace rows are
editited in the backend. The handling when deleting
a sys_workspace_stage is also slightly improved by
adding a log entry stating affected record counts.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
  • Verified V +2 Done
    • Christian Kuhn +2
    • core-ci +1 CI

Issues 1

Files 4

Review log 34

  1. Christian Kuhn uploaded patch set 1 06/25/25, 11:46

  2. core-ci voted on patch set 1 V +1 06/25/25, 11:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80851

  3. Christian Kuhn voted on patch set 1 CR +2 V +2 06/25/25, 12:02

  4. Christian Kuhn merged patch set 2 06/25/25, 12:02