Review main Abandoned

89876[TASK] Use runTests npm nodejs22-chrome image due to fontconfig

Garvin Hicking CR -1 V 0 Easy +4 −4 updated 06/25/25, 14:00

Commit message

runTests.sh currently utilizes "ghcr.io/typo3/core-testing-nodejs22:1.2"
as a base image for most "npm" executions.

The alternate image "ghcr.io/typo3/core-testing-nodejs22-chrome:1.2" is
mainly used for JS unit testing, and differs from the aforementioned
image in that it provides chromium/X11 integration.

The regular "npm build" process utilizes package `sharp` via `libvips`
which seems to have a dependency on fontconfig. It does not report errors
when using the nodejs22-chrome image.

So the runTests.sh build process now utilizes this docker image for
operations.

Review

  • Code review CR -1
    • Benjamin Franzke -1
  • Verified V 0
    • core-ci +1 CI

Issues 1

Files 1

Review log 45

  1. Garvin Hicking uploaded patch set 1 06/25/25, 13:03

  2. core-ci voted on patch set 1 V +1 06/25/25, 13:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80858

  3. Benjamin Franzke commented on patch set 1 CR -1 06/25/25, 13:15

    I'd honestly prefer to include `fontconfig` in the `nodejs22` images instead. But I just learned that we may get rid of the `sharp` dependency, since it is currently evaluated if we switch to a different flag-provider that does not require processing via sharp. So I'd block this for now, hope that's fine.
  4. Garvin Hicking commented on patch set 1 06/25/25, 14:00

    Reply Unresolved

    Sure, alright. As it currently has no impact on the CI results other than a "warning" I'll abandon this.
  5. Garvin Hicking abandoned the change 06/25/25, 14:00

    see comment