Review main Merged Breaking

89885[!!!][TASK] Remove TCA field related `search` options

Oli Bartsch CR +2 V +2 Normal +139 −107 updated 06/25/25, 19:15

Commit message

The TCA field `search` configuration is removed.
This includes the following options:

- search[case]
- search[pidonly]
- search[andWhere]

These options were not used in TYPO3 Core or
common extensions, offered unclear benefits,
and added unnecessary complexity to TCA
configuration.

Their removal is part of our effort to simplify
and modernize TCA.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Stefan Bürk +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 7

Review log 67

  1. Oli Bartsch uploaded patch set 1 06/25/25, 15:44

  2. core-ci voted on patch set 1 V +1 06/25/25, 15:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80877

  3. Andreas Kienast commented on patch set 1 06/25/25, 16:02

    SearchTermRestriction.php:76

    I like that it was only checked whether `case` was defined but not its boolean status.
  4. Andreas Kienast voted on patch set 1 CR +1 06/25/25, 16:07

  5. Stefan Bürk commented on patch set 1 CR +1 V +1 06/25/25, 17:59

    SearchTermRestriction.php:76 Reply Unresolved

    That check was broken anyway .. it checked for value `check` in `search` array and not for the key `case` ... maybe that have been chaned in the passed and missed to be adopted here ? That means that `search['case'] = true/false` was never detected anyway ...
  6. Georg Ringer voted on patch set 1 CR +2 V +2 06/25/25, 19:14

  7. Georg Ringer merged patch set 2 06/25/25, 19:15