Review main Merged

89887[BUGFIX] Ensure SuggestWizard's `maxItemsInResultList` to be an integer

Andreas Kienast CR +2 V +2 Easy +1 −1 updated 06/25/25, 17:02

Commit message

Setting the option
`TCEFORM.<table>.<field>.suggest.default.maxItemsInResultList` may lead
to PHP type errors as the value is always treated as a string being
passed to `array_splice()`.

Note that this issue only occurs if the returned search result is larger
than the desired amount.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Andreas Nedbal +1
    • Oli Bartsch +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Andreas Nedbal +1
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 56

  1. Andreas Kienast uploaded patch set 1 06/25/25, 16:28

  2. core-ci voted on patch set 1 V +1 06/25/25, 16:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80879

  3. Andreas Nedbal voted on patch set 1 CR +1 V +1 06/25/25, 16:44

  4. Oli Bartsch voted on patch set 1 CR +1 V +1 06/25/25, 16:50

  5. Andreas Kienast voted on patch set 1 CR +2 V +2 06/25/25, 16:50

  6. Andreas Kienast merged patch set 2 06/25/25, 17:02