Review main Merged

89891[BUGFIX] Respect `#[IgnoreValidation]` attribute in controllers only

Elias Häußler CR +2 V +2 Normal +74 −20 updated 08/12/25, 21:51

Commit message

The `#[IgnoreValidation]` attribute can be used to disable a previously
configured validation for a property or method. In contrast to the
`#[Validate]` attribute, it was previously possible to attach an
`#[IgnoreValidation]` attribute to every class method. Since it is only
relevant in controller context and to streamline the behavior with the
`#[Validate]` attribute, `#[IgnoreValidation]` attributes are no longer
respected in non-controller class methods.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Garvin Hicking +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 1

Files 6

Review log 1114

  1. Elias Häußler uploaded patch set 1 06/25/25, 17:07

  2. core-ci voted on patch set 1 V +1 06/25/25, 17:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80886

  3. Elias Häußler uploaded patch set 2 V +1 08/08/25, 12:19

  4. core-ci voted on patch set 2 V +1 08/08/25, 12:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83014

  5. Elias Häußler updated the commit message in patch set 3 V +1 08/08/25, 12:27

  6. Elias Häußler marked it ready for review 08/08/25, 12:28

  7. Oliver Klee commented on patch set 3 08/08/25, 12:32

    DummyClassWithIgnoreValidationAttribute.php:23

    This comment needs to be changed as well.
  8. core-ci voted on patch set 3 V +1 08/08/25, 12:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83015

  9. Elias Häußler commented on patch set 3 08/12/25, 13:07

    DummyClassWithIgnoreValidationAttribute.php:23 Reply

    Hi @typo3-coding@oliverklee.de, what changes do you expect in the comment? :)
  10. Oliver Klee commented on patch set 3 08/12/25, 14:19

    DummyClassWithIgnoreValidationAttribute.php:23 Reply

    Ah, my bad. I misread the class comment to give an example of an annotation, not as a reference to the corresponding class. So the comment is fine.
  11. Christian Kuhn voted on patch set 3 CR +1 V +1 08/12/25, 21:20

  12. Garvin Hicking voted on patch set 3 CR +1 V +1 08/12/25, 21:51

  13. Christian Kuhn voted on patch set 3 CR +2 V +2 08/12/25, 21:51

  14. Christian Kuhn merged patch set 4 08/12/25, 21:51