89891[BUGFIX] Respect `#[IgnoreValidation]` attribute in controllers only
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Garvin Hicking +1
-
Verified V +2 Done
- Christian Kuhn +2
- Garvin Hicking +1
- core-ci +1 CI
Issues 1
Files 6
- typo3/sysext/extbase/Classes/Reflection/ClassSchema.php+13 −9
- typo3/sysext/extbase/Tests/Unit/Reflection/ClassSchema/MethodParameterTest.php+29 −2
- typo3/sysext/extbase/Tests/Unit/Reflection/Fixture/DummyClassWithIgnoreValidationAttribute.php3renamed+2 −2
- typo3/sysext/extbase/Tests/Unit/Reflection/Fixture/DummyClassWithIgnoreValidationDoctrineAnnotation.phpcopied+9 −4
- typo3/sysext/extbase/Tests/Unit/Reflection/Fixture/DummyControllerWithIgnoreValidationAttribute.phpcopied+11 −2
- typo3/sysext/extbase/Tests/Unit/Reflection/Fixture/DummyControllerWithIgnoreValidationDoctrineAnnotation.php+10 −1
Review log 1114
-
Elias Häußler uploaded patch set 1 06/25/25, 17:07
-
core-ci voted on patch set 1 V +1 06/25/25, 17:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80886
-
Elias Häußler uploaded patch set 2
V +108/08/25, 12:19 -
core-ci voted on patch set 2 V +1 08/08/25, 12:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83014
-
Elias Häußler updated the commit message in patch set 3
V +108/08/25, 12:27 -
Elias Häußler marked it ready for review 08/08/25, 12:28
-
Oliver Klee commented on patch set 3 08/08/25, 12:32
-
core-ci voted on patch set 3 V +1 08/08/25, 12:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83015
-
Elias Häußler commented on patch set 3 08/12/25, 13:07
DummyClassWithIgnoreValidationAttribute.php:23ReplyHi @typo3-coding@oliverklee.de, what changes do you expect in the comment? :) -
Oliver Klee commented on patch set 3 08/12/25, 14:19
DummyClassWithIgnoreValidationAttribute.php:23ReplyAh, my bad. I misread the class comment to give an example of an annotation, not as a reference to the corresponding class. So the comment is fine. -
Christian Kuhn voted on patch set 3 CR +1 V +1 08/12/25, 21:20
-
Garvin Hicking voted on patch set 3 CR +1 V +1 08/12/25, 21:51
-
Christian Kuhn voted on patch set 3 CR +2 V +2 08/12/25, 21:51
-
Christian Kuhn merged patch set 4 08/12/25, 21:51
DummyClassWithIgnoreValidationAttribute.php:23