Review main Merged

89897[BUGFIX] Allow to use default TCEMAIN.preview settings in workspace preview URLs

Benni Mack CR +2 V +2 Normal +27 −33 updated 06/26/25, 19:18

Commit message

When workspaces is used, one can use the TSconfig
setting

options.workspaces.previewPageId.tx_mytable = field:pid

which overrules the default option

TCEMAIN.preview.tx_mytable.previewPageId = 123

which is OK.

However, the previous code did not evaluate further
TCEMAIN.preview settings such as "fieldToParameterMap"
at all, as the if condition was set wrongly.

In addition, these settings now apply for tt_content as
well.

See https://docs.typo3.org/c/typo3/cms-workspaces/main/en-us/Administration/Configuration/Index.html#pagetsconfig-options-workspaces-previewpageid

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Andreas Nedbal +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Andreas Nedbal +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 56

  1. Benni Mack uploaded patch set 1 06/25/25, 20:18

  2. core-ci voted on patch set 1 V +1 06/25/25, 20:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80913

  3. Oli Bartsch voted on patch set 1 CR +1 V +1 06/26/25, 15:38

  4. Andreas Nedbal voted on patch set 1 CR +1 V +1 06/26/25, 18:58

  5. Oli Bartsch voted on patch set 1 CR +2 V +2 06/26/25, 19:18

  6. Oli Bartsch merged patch set 2 06/26/25, 19:18