Review 13.4 Merged

89907[TASK] Simplify workspaces GridDataService

Christian Kuhn CR +2 V +2 Hard +77 −190 updated 06/26/25, 13:09

Commit message

Workspaces GridDataService is the main class that takes
care of creating the data used to render the workspace
module main data table. This table has various bugs that
cripple usability.

This is a clean-up patch to prepare bug fixes:

* The rendered record list sorting is a nightmare. Back
  then with ExtJS the table was sortable by columns, which
  wasn't a great solution either. That sorting feature has
  been removed at some point in the UI, while keeping
  the server side implementation. We need a better approach
  in general that better reflects the "known" default sorting
  of elements in the backend. To prepare this, we remove the
  currently unused parts from the codebase, which
  avoids quite a bit of indirection within the code flow.
* The record grouping approach is limited and tends to
  render fishy header rows in the UI where child rows expand
  at funny places and don't collapse properly. The server
  side code is simplified to prepare manageable improvements.
* To tame class state and make state changes obvious, we
  inline the remaining $dataArray class property and hand
  it around in sub methods instead. The other two properties
  become obsolete due to the sorting related simplification,
  making the class stateless.
* We inline the remaining constants: Their "gridcolumn" naming
  was misleading which does not improve understanding their
  meaning and their string values are used in typescript
  again so there is a duplication anyway. It is possible the
  only cross-class-usage within CollectionService can be
  avoided with yet another refactoring step since that part of
  the codebase is very hard to follow as well and should
  receive streamlining love.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
  • Verified V +2 Done
    • Christian Kuhn +2
    • core-ci +1 CI

Issues 1

Files 5

Review log 46

  1. Christian Kuhn uploaded patch set 1 06/26/25, 07:36

  2. core-ci voted on patch set 1 V -1 06/26/25, 07:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80949

  3. Christian Kuhn uploaded patch set 2 V -1 06/26/25, 12:55

  4. core-ci voted on patch set 2 V +1 06/26/25, 13:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80985

  5. Christian Kuhn voted on patch set 2 CR +2 V +2 06/26/25, 13:09

  6. Christian Kuhn merged patch set 3 06/26/25, 13:09