Review main Merged

89908[BUGFIX] Fix runTest.sh rendering command

Garvin Hicking CR +2 V +2 Easy +1 −1 updated 06/26/25, 08:43

Commit message

Sadly the command introduced with #106982 had the workspace argument
set wrongly to not be applied to the docker workspace, but the app's
workspace.

This lead to the "guides.xml" files not properly be integrated. This
would then not load possible external interlink inventories, leading
to a rendering failure for EXT:redirects.

With this patch:

*  The "-w" option properly applies to docker context to set the
   workspace.

* The "--minimal-test" option for the app is removed, so that rendered
  artifacts can be collected on demand. Removing this adds 25% more
  rendering time at the benefit of having all artifacts. For a possible
  nightly integration this should be acceptable.

* A "--config=Documentation" option is added to the app run, so that
  it is ensured to load "guides.xml" in all cases.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
    • Lina Wolf +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Garvin Hicking +2
    • Lina Wolf +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 68

  1. Garvin Hicking uploaded patch set 1 06/26/25, 07:49

  2. Stefan Bürk updated the commit message in patch set 2 06/26/25, 07:51

  3. Stefan Bürk voted on patch set 2 CR +1 V +1 06/26/25, 07:53

  4. Lina Wolf voted on patch set 2 CR +1 V +1 06/26/25, 07:54

  5. core-ci voted on patch set 1 V +1 06/26/25, 07:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80950

  6. core-ci voted on patch set 2 V +1 06/26/25, 07:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80951

  7. Garvin Hicking voted on patch set 2 CR +2 V +2 06/26/25, 08:17

  8. Garvin Hicking merged patch set 3 06/26/25, 08:43