Review main Merged

89909[BUGFIX] Avoid obsolete requests in tree filtering

Andreas Nedbal CR +2 V +2 Easy +12 −2 updated 06/27/25, 08:36

Commit message

If filter responses take longer than the debounce timeout
(~250ms), the filter endpoints could end up handling multiple
requests at the same time, delivering (now) unexpected results
at the end.

This change implements request aborting in case a new request
is fired while a current one is still running.

Review

  • Code review CR +2 Done
    • Andreas Nedbal +2
    • Garvin Hicking +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Andreas Nedbal +2
    • Garvin Hicking +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 810

  1. Andreas Nedbal uploaded patch set 1 06/26/25, 08:00

  2. core-ci voted on patch set 1 V +1 06/26/25, 08:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80952

  3. Garvin Hicking commented on patch set 1 CR +1 V +1 06/26/25, 09:13

    Nice! I added a "sleep(5)" in typo3/sysext/backend/Classes/Controller/Page/TreeController.php->filterDataAction to simulate this. The events are properly aborted and only the last search result will be revealed.
  4. Andreas Kienast uploaded patch set 2 CR +1 V +1 06/27/25, 07:43

  5. Andreas Kienast commented on patch set 2 06/27/25, 07:44

    I've modified the code to initialize `currentFilterRequest` being `null` as it's set to `null` later on anyway.
  6. Andreas Kienast voted on patch set 2 CR +1 V +1 06/27/25, 07:44

  7. core-ci voted on patch set 2 V +1 06/27/25, 07:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81060

  8. Garvin Hicking voted on patch set 2 CR +1 V +1 06/27/25, 08:13

  9. Andreas Nedbal voted on patch set 2 CR +2 V +2 06/27/25, 08:36

  10. Andreas Nedbal merged patch set 3 06/27/25, 08:36