Review main Abandoned

89912[BUGFIX] Fix some flaws in SuggestWizard

Andreas Kienast CR 0 V 0 Normal +62 −57 updated 11/21/25, 07:38

Commit message

This commit aims to fix some flaws in the SuggestWizard area that exists
since their introduction in 2009.

One bigger issue is that the configuration of `maxItemsInResultList`,
that *may* exist on a per-column-basis is potentially used for the
whole record set, which leads to unintended behavior if multiple tables
are queried. To solve this, the global configuration is explicitly used
to check for that option.

Another issue is that all configured tables are queried without checking
whether this is necessary as the `maxItemsInResultList` constraint may
be fulfilled already. The existing code is moved into the loop to be
able to avoid querying further tables.

The `SuggestWizardDefaultReceiver` also got some improvements. When
`queryTable()` is called, two database queries are executed:

* get the actual set of items
* get the total amount of available items

The result of the latter query is used to check whether more records
need to be queried. Since this will result in another concrete query
anyway, we can safely remove the "counting" query.

Review

  • Code review CR 0
  • Verified V 0
    • core-ci +1 CI

Issues 1

Files 2

Review log 1525

  1. Andreas Kienast uploaded patch set 1 06/26/25, 08:18

  2. Andreas Kienast uploaded patch set 2 06/26/25, 08:21

  3. core-ci voted on patch set 1 V -1 06/26/25, 08:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80957

  4. core-ci voted on patch set 2 V -1 06/26/25, 08:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80959

  5. Andreas Kienast uploaded patch set 3 V -1 06/26/25, 11:52

  6. core-ci voted on patch set 3 V +1 06/26/25, 12:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80980

  7. Andreas Kienast uploaded patch set 4 V +1 06/26/25, 12:04

  8. core-ci voted on patch set 4 V +1 06/26/25, 12:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80981

  9. Georg Ringer commented on patch set 4 06/26/25, 19:48

    SuggestWizardDefaultReceiver.php:135

    I guess that can be removed?
  10. Andreas Kienast commented on patch set 4 06/26/25, 20:43

    SuggestWizardDefaultReceiver.php:135 Reply

    the other way around – this line needs to be uncommented and the one below can be removed
  11. Andreas Kienast uploaded patch set 5 V +1 06/27/25, 06:18

  12. Andreas Kienast commented on patch set 5 06/27/25, 06:18

    SuggestWizardDefaultReceiver.php:135 Reply

    Done
  13. Andreas Kienast updated the commit message in patch set 6 06/27/25, 06:19

  14. Andreas Kienast updated the commit message in patch set 7 06/27/25, 06:21

  15. core-ci voted on patch set 5 V +1 06/27/25, 06:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81053

  16. core-ci voted on patch set 6 V +1 06/27/25, 06:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81054

  17. core-ci voted on patch set 7 V +1 06/27/25, 06:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81056

  18. Andreas Kienast uploaded patch set 8 V +1 07/15/25, 09:45

  19. Andreas Kienast uploaded patch set 9 07/15/25, 09:46

  20. core-ci voted on patch set 8 V -1 07/15/25, 09:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81732

  21. core-ci voted on patch set 9 V +1 07/15/25, 09:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81733

  22. Simon Schaufelberger voted on patch set 9 CR +1 07/17/25, 15:37

  23. Andreas Kienast rebased onto patch set 10 CR +1 V +1 10/13/25, 11:33

  24. core-ci voted on patch set 10 V +1 10/13/25, 11:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86539

  25. Andreas Kienast abandoned the change 11/21/25, 07:38