Review main Merged

89914[TASK] Always reconstitute TSFE in PageContentErrorHandler

TYPO3com CR +2 V +2 Easy +5 −6 updated 06/26/25, 20:31

Commit message

When calling persistAll EXT:solr will initialize all Sites.
Sites with root pages of type Shortcut to restricted pages
will trigger PageNotFound handling.

Before this change, given exceptionalErrors, if an error
was encountered it would throw an exception which was caught
too late and TSFE was lost.

With this change, regardless of exceptions, TSFE will be kept.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Andreas Nedbal +1
    • Oli Bartsch +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Andreas Nedbal +1
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 710

  1. TYPO3com uploaded patch set 1 06/26/25, 10:36

  2. core-ci voted on patch set 1 V +1 06/26/25, 10:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80972

  3. Andreas Nedbal updated the commit message in patch set 2 V +1 06/26/25, 19:42

  4. Georg Ringer voted on patch set 2 CR +1 V +1 06/26/25, 19:43

  5. Andreas Nedbal updated the commit message in patch set 3 CR +1 V +1 06/26/25, 19:44

  6. Andreas Nedbal voted on patch set 3 CR +1 V +1 06/26/25, 19:45

  7. Oli Bartsch voted on patch set 3 CR +1 V +1 06/26/25, 19:46

  8. core-ci voted on patch set 3 V +1 06/26/25, 20:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81029

  9. Stefan Bürk voted on patch set 3 CR +2 V +2 06/26/25, 20:19

  10. Stefan Bürk merged patch set 4 06/26/25, 20:31