Review main Merged

89918[TASK] Do not use full TYPO3 context in early permission checks

Oli Bartsch CR +2 V +2 Easy +5 −8 updated 06/27/25, 15:06

Commit message

`PermissionsCheck` verifies whether the configured database
has the required permissions. For this purpose, it is not
necessary to use TYPO3's Connection and QueryBuilder.

Using QueryBuilder too early can lead to issues, since it
applies default restrictions that rely on TCA and the
TcaSchemaFactory, which may not be available during early
initialization.

This change replaces QueryBuilder with a plain Doctrine
connection for simple permission checks, avoiding unnecessary
dependencies on TYPO3 internals at this stage.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Garvin Hicking +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 812

  1. Oli Bartsch uploaded patch set 1 06/26/25, 13:38

  2. core-ci voted on patch set 1 V +1 06/26/25, 13:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80988

  3. Oli Bartsch updated the commit message in patch set 2 V +1 06/27/25, 10:21

  4. core-ci voted on patch set 2 V +1 06/27/25, 10:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81071

  5. Oli Bartsch commented on patch set 3 V +1 06/27/25, 10:41

    Published edit on patch set 2.
  6. Garvin Hicking voted on patch set 3 CR +1 V +1 06/27/25, 10:45

  7. core-ci voted on patch set 3 V +1 06/27/25, 10:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81074

  8. Oli Bartsch uploaded patch set 4 CR +1 V +1 06/27/25, 11:02

  9. Garvin Hicking voted on patch set 4 CR +1 V +1 06/27/25, 11:03

  10. core-ci voted on patch set 4 V +1 06/27/25, 11:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81075

  11. Stefan Bürk voted on patch set 4 CR +2 V +2 06/27/25, 14:58

  12. Stefan Bürk merged patch set 5 06/27/25, 15:06