Review main Merged

8992[BUGFIX] show uid of reference in show_item.php

Johannes Feustel CR +2 V +2 Easy +5 −1 updated 06/03/13, 20:49

Commit message

The uid of referenced records is not shown anymore and if there are
more items with same title, there is no easy way to identify the
record in the backend.

Solution is to add a column for the uid and page information in the
title attribute of the uid.

Review

  • Code review CR +2
    • Thorsten Kahler +2
    • Philipp Gampe +1
  • Verified V +2
    • Thorsten Kahler +2
    • Philipp Gampe +1

Files 1

Review log 35

Show 10 earlier messages
  1. Thorsten Kahler uploaded patch set 3 02/13/12, 15:08

  2. Thorsten Kahler commented on patch set 4 02/13/12, 15:08

    (2 inline comments)
  3. Thorsten Kahler uploaded patch set 4 02/13/12, 15:08

  4. Markus Klein commented on patch set 2 02/13/12, 15:08

    Looks good to me, but someone else must approve Fixed missing </span>
  5. Markus Klein uploaded patch set 2 02/13/12, 15:08

  6. Johannes Feustel commented on patch set 4 02/13/12, 15:08

    (2 inline comments)

    show_item.php:492

    Can a new column be introduced in a bugfix release?

    show_item.php:505

    htmlspecialchars is already in getRecordTitle(). I think there should be some whitespaces and "page" should be localized.

    show_item.php:505 Reply

    htmlspecialchars() is alredy done in getRecordTitlePrep() Edit: just saw that $prep parameter is not set. Probably because it should not crop the page title in the tooltip. I will re-add htmlspecialchars() soon.
  7. Thorsten Kahler commented on patch set 5 02/13/12, 15:08

    (1 inline comment)
  8. Thorsten Kahler commented on patch set 5 1 comment 02/13/12, 15:08

    Verified; I would prefer that you didn't submit this Code works for me but a htmlspecialchars() should be added for security reasosns.
  9. Markus Klein commented on patch set 5 02/13/12, 15:08

    (1 inline comment)
  10. Thorsten Kahler commented on patch set 6 2 comments 02/13/12, 15:08

    I would prefer that you didn't submit this
  1. Markus Klein commented on patch set 6 02/13/12, 15:08

    Would it be better to use getRecordTitle( , , FALSE, TRUE) This would simply print "No title" without any <em> around.
  2. Markus Klein uploaded patch set 6 02/13/12, 15:08

  3. Markus Klein commented on patch set 6 02/13/12, 15:08

    (1 inline comment)
  4. Thorsten Kahler commented on patch set 7 1 comment 02/13/12, 15:08

    Verified; I would prefer that you didn't submit this
  5. Markus Klein uploaded patch set 7 02/13/12, 15:08

  6. Markus Klein commented on patch set 7 02/13/12, 15:08

    (1 inline comment)
  7. Thorsten Kahler commented on patch set 8 V 0 02/13/12, 15:08

    by team member; Looks good to me, approved
  8. Markus Klein uploaded patch set 8 02/13/12, 15:08

  9. Johannes Feustel commented on patch set 5 02/13/12, 15:08

    (1 inline comment)
  10. Johannes Feustel uploaded patch set 5 02/13/12, 15:08

  11. Johannes Feustel commented on patch set 6 02/13/12, 15:08

    Looks good to me, but someone else must approve
  12. Johannes Feustel commented on patch set 6 02/13/12, 15:08

    (1 inline comment)
  13. Philipp Gampe commented on patch set 6 02/13/12, 15:08

    No score One issue ... if the referenced page is the TYPO3 root (pid=0) it says "<em>[No title}</em>" in the popup. Maybe there needs to be some extra logic to handle this case, because this is really ugly.

    show_item.php:492

    That looks strange. Maybe use Uid or uid instead? Or make "Unique Id" a label?
  14. Philipp Gampe voted on patch set 6 V 0 1 comment 02/13/12, 15:08

  15. Philipp Gampe commented on patch set 7 02/13/12, 15:08

    Verified; Looks good to me, but someone else must approve
  16. Philipp Gampe commented on patch set 8 02/13/12, 15:08

    Verified; Looks good to me, but someone else must approve Sorry, I overlooked that one too.
  17. Mr. Jenkins commented on patch set 1 02/13/12, 15:08

  18. Mr. Jenkins commented on patch set 2 02/13/12, 15:08

  19. Mr. Jenkins commented on patch set 3 02/13/12, 15:08

  20. Mr. Jenkins commented on patch set 4 02/13/12, 15:08

  21. Mr. Jenkins commented on patch set 5 02/13/12, 15:08

  22. Mr. Jenkins commented on patch set 6 02/13/12, 15:08

  23. Mr. Jenkins commented on patch set 7 02/13/12, 15:08

  24. Mr. Jenkins commented on patch set 8 02/13/12, 15:08

  25. Thorsten Kahler merged patch set 8 02/13/12, 15:08