Review main Merged

89923[BUGFIX] Restore DBAL DSN URL support in ConnectionPool

Thomas Maroschik CR +2 V +2 Normal +70 −0 updated 06/26/25, 20:11

Commit message

Restores support for the `url` parameter (DSN string) for database
connection configurations.

This functionality was available in TYPO3 v12 but stopped working in v13
due to an underlying change in Doctrine DBAL. With DBAL v3, automatic
parsing of the `url` parameter was deprecated and later removed.

This patch re-introduces the functionality by explicitly using the
`Doctrine\DBAL\Tools\DsnParser` to parse the DSN URL if the `url`
key is present in the connection parameters. This ensures that a
DSN string is properly resolved into the individual connection parts
(host, dbname, user, etc.) before the connection is established.

The change is applied in `ConnectionPool::getConnectionParams()` and
restores the previous behavior without affecting existing setups that
do not use the DSN `url` parameter.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Garvin Hicking +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 68

  1. Thomas Maroschik uploaded patch set 1 06/26/25, 18:43

  2. core-ci voted on patch set 1 V -1 06/26/25, 18:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81011

  3. Thomas Maroschik uploaded patch set 2 V -1 06/26/25, 19:12

  4. core-ci voted on patch set 2 V +1 06/26/25, 19:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81015

  5. Stefan Bürk voted on patch set 2 CR +1 V +1 06/26/25, 19:32

  6. Garvin Hicking voted on patch set 2 CR +1 V +1 06/26/25, 19:56

  7. Stefan Bürk voted on patch set 2 CR +2 V +2 06/26/25, 20:00

  8. Stefan Bürk merged patch set 3 06/26/25, 20:11