Review main Merged

89932[BUGFIX] Allow disabling checkboxes with default in user settings

Oli Bartsch CR +2 V +2 Easy +2 −2 updated 06/30/25, 09:54

Commit message

Previously, it was not possible to disable a
checkbox field in user settings, when it had
a default value, set to true, because the
evaluation treated "falsy" values like 0 as
if no value was set.

This change adjusts the logic to distinguish
between null (unset) and false (explicitly set).

Now, if the value is null and a default is
configured, the default is applied. Otherwise,
the explicit value (including false) is respected.

This ensures checkboxes can be properly disabled
even if they default to true.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Garvin Hicking +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Garvin Hicking +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 56

  1. Oli Bartsch uploaded patch set 1 06/27/25, 07:47

  2. core-ci voted on patch set 1 V +1 06/27/25, 07:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81061

  3. Garvin Hicking voted on patch set 1 CR +1 V +1 06/27/25, 09:10

  4. Simon Schaufelberger voted on patch set 1 CR +1 V +1 06/30/25, 08:06

  5. Oli Bartsch voted on patch set 1 CR +2 V +2 06/30/25, 09:54

  6. Oli Bartsch merged patch set 2 06/30/25, 09:54