89938[BUGFIX] Preserve workspace history during publishing
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Benjamin Franzke +1
- Oli Bartsch +1
-
Verified V +2 Done
- Benni Mack +2
- Benjamin Franzke +1
- Oli Bartsch +1
- core-ci +1 CI
Issues 1
Files 6
- typo3/sysext/backend/Classes/Controller/ContentElement/ElementHistoryController.php+1 −1
- typo3/sysext/backend/Classes/History/RecordHistory.php+3 −0
- typo3/sysext/backend/Resources/Private/Language/locallang_show_rechis.xlf+3 −0
- typo3/sysext/backend/Resources/Private/Partials/RecordHistory/History.html+1 −0
- typo3/sysext/core/Classes/DataHandling/History/RecordHistoryStore.php+43 −11
- typo3/sysext/workspaces/Classes/Hook/DataHandlerHook.php6+25 −14
Review log 1113
-
Benni Mack uploaded patch set 1 06/27/25, 16:00
-
core-ci voted on patch set 1 V +1 06/27/25, 16:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81080
-
Benjamin Franzke commented on patch set 1 V -1 07/04/25, 09:48
-
Benjamin Franzke commented on patch set 1 07/04/25, 09:53
DataHandlerHook.php:446ReplyFrom a semantics perspective `publishSingleRecord()` feels more correct to me, because the action is dispatched on the versioned record and instructs apply this to the live id. …but there must be a reason why even publish and discard within `executeSelectionAction` use different semantics (which I do not know)… -
Benjamin Franzke commented on patch set 1 07/04/25, 10:07
DataHandlerHook.php:446ReplyForget my previous analysis, the issue is a different one: It works only for existing records, but not for newly added records, because that that means we do not get here, but bail out early and handle this case via `DataHandlerHook::publishNewRecord`. -
Benjamin Franzke commented on patch set 1 07/04/25, 10:25
DataHandlerHook.php:446ReplyIt is more complicated. * `⇆` is broken for existing (because of swapped t3ver_oid and uid) *and* new records. * `executeSelectionAction` works for existing records, but not for new records (because of DataHandlerHook::publishNewRecord) Also, if I'm not absolutely mistaken JS get's the naming wrong and submits t3ver_oid as a version id and the version-records uid as the live id, which is wrong: https://github.com/TYPO3/typo3/blob/191fc1d95143cc304ca4c0bd4299d4ebb8e42de5/Build/Sources/TypeScript/workspaces/backend.ts#L180-L181 -
Benjamin Franzke commented on patch set 1 CR +1 V +1 07/04/25, 11:08
DataHandlerHook.php:446ReplyI'm so sorry, now `⇆` is working for existing records, I don't know what went wrong If I was just dumb. The "problem" that "published" is not logged for new records persists, but I understand that that is less problematic, since new records already use the later-liveid and therefore history is preserved "automatically". I'm resolving here. -
Benni Mack uploaded patch set 2
CR +1V +107/24/25, 16:11 -
core-ci voted on patch set 2 V +1 07/24/25, 16:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82267
-
Oli Bartsch voted on patch set 2 CR +1 V +1 07/25/25, 14:41
-
Benjamin Franzke commented on patch set 2 CR +1 V +1 07/26/25, 10:38
DataHandlerHook.php:446ReplyNew record publishing works now, thanks! -
Benni Mack voted on patch set 2 CR +2 V +2 07/26/25, 18:50
-
Benni Mack merged patch set 3 07/26/25, 18:50
DataHandlerHook.php:446