Review 13.4 Merged

89939[BUGFIX] Correct usage of IsFileSelectableEvent

Benjamin Kott CR +2 V +2 Normal +89 −13 updated 06/28/25, 03:00

Commit message

During the rework of the FileList, the IsFileSelectableEvent was not
migrated correctly. Instead of remaining available only in the
FileBrowser, it was moved to the FileList. Additionally, its purpose and
usage were misunderstood—likely due to the challenge of naming things
clearly.

This resulted in patches that attempted to fix the original issue by
applying workarounds, without addressing the root cause. Unfortunately,
these patches also introduced new regressions, further complicating the
behavior and stability of the FileList.

The underlying concept of the FileList assumes that each resource has a
primary action, which must be implemented by the consuming view.
Displaying disabled items was never intended.

The event was introduced to provide fine-grained control over which
files a user may select. This control should reflect the FileList's
display logic. However, it was mistakenly applied to the selectable
option, which has a different meaning: a file that is not selectable
should never be shown to the user in the first place.

This patch removes the related workarounds in the FileList and
introduces a new matcher, since the current matching logic only supports
OR operations. The event has now been relocated and is exclusively used
in the FileBrowser, as originally intended.

Review

  • Code review CR +2 Done
    • Benjamin Kott +2
  • Verified V +2 Done
    • Benjamin Kott +2
    • core-ci +1 CI

Issues 2

Files 4

Review log 34

  1. Benjamin Kott commented on patch set 1 06/28/25, 02:43

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 06/28/25, 02:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81083

  3. Benjamin Kott voted on patch set 1 CR +2 V +2 06/28/25, 03:00

  4. Benjamin Kott merged patch set 2 06/28/25, 03:00