Merge conflict Gerrit cannot merge this change. It needs a rebase onto main.
89940[FEATURE] Allow to restrict HTTP methods for extbase actions
Commit message
Test this change
Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch
- Check out patch set 10
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/40/89940/10 && git checkout FETCH_HEAD - Cherry-pick onto main
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/40/89940/10 && git cherry-pick FETCH_HEAD
Review
-
Code review CR 0 Needs a vote
-
Verified V 0 Needs a vote
- core-ci +1 CI
Issues 1
Files 20
- typo3/sysext/beuser/Tests/Functional/Controller/BackendUserControllerTest.php+1 −0
- typo3/sysext/core/Classes/Error/AbstractExceptionHandler.php+1 −0
- typo3/sysext/extbase/Classes/Attribute/AllowsHttpMethods.phpnew+41 −0
- typo3/sysext/extbase/Classes/Mvc/Controller/ActionController.php+11 −0
- typo3/sysext/extbase/Classes/Mvc/Exception/MethodNotAllowedException.phpnew+25 −0
- typo3/sysext/extbase/Classes/Mvc/Validation/CompositeRequestValidator.phpnew+46 −0
- typo3/sysext/extbase/Classes/Mvc/Validation/HttpMethodRequestValidator.phpnew+97 −0
- typo3/sysext/extbase/Classes/Mvc/Validation/RequestValidatorInterface.phpnew+32 −0
- typo3/sysext/extbase/Classes/Reflection/ClassSchema/Method.php+9 −0
- typo3/sysext/extbase/Classes/Reflection/ClassSchema.php+17 −9
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/blog_example/Classes/Controller/BlogPostEditingController.php+8 −0
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/blog_example/Resources/Private/Templates/BlogPostEditing/TestGetPost.htmlnew+3 −0
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/blog_example/ext_localconf.php+2 −2
- typo3/sysext/extbase/Tests/Functional/Mvc/Controller/ActionControllerArgumentTest.php+9 −6
- typo3/sysext/extbase/Tests/Functional/Mvc/Controller/ActionControllerTest.php+30 −22
- typo3/sysext/extbase/Tests/Functional/Mvc/Controller/BlogPostEditingControllerTest.php+62 −0
- typo3/sysext/extbase/Tests/Functional/Mvc/Controller/ControllerArgumentsMappingTest.php+7 −5
- typo3/sysext/extbase/Tests/Functional/Mvc/Validation/ActionControllerValidationTest.php+25 −9
- typo3/sysext/form/Tests/Functional/Controller/FormEditorControllerTest.php+13 −9
- typo3/sysext/form/Tests/Functional/Controller/FormManagerControllerTest.php+35 −24
Review log 1525
-
Torben Hansen uploaded patch set 1 06/29/25, 18:14
-
core-ci voted on patch set 1 V +1 06/29/25, 18:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81114
-
Simon Schaufelberger commented on patch set 1 06/29/25, 19:04
Thank you very much for putting effort into this really exciting new feature! Very much appreciated! -
Torben Hansen uploaded patch set 2
V +111/10/25, 14:56 -
core-ci voted on patch set 2 V +1 11/10/25, 15:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88860
-
Elias Häußler uploaded patch set 3
V +111/10/25, 16:01 -
Torben Hansen marked it work in progress 11/10/25, 16:08
-
core-ci voted on patch set 3 V -1 11/10/25, 16:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88874
-
Elias Häußler uploaded patch set 4
V -111/10/25, 18:35 -
core-ci voted on patch set 4 V -1 11/10/25, 18:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88894
-
Elias Häußler uploaded patch set 5
V -111/10/25, 20:50 -
core-ci voted on patch set 5 V -1 11/10/25, 21:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88908
-
Elias Häußler uploaded patch set 6
V -111/10/25, 21:39 -
core-ci voted on patch set 6 V +1 11/10/25, 21:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88916
-
Torben Hansen uploaded patch set 7
V +111/11/25, 08:25 -
core-ci voted on patch set 7 V -1 11/11/25, 08:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88952
-
Torben Hansen uploaded patch set 8
V -111/11/25, 08:38 -
core-ci voted on patch set 8 V +1 11/11/25, 08:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88954
-
Torben Hansen updated the commit message in patch set 9
V +111/11/25, 10:31 -
core-ci voted on patch set 9 V +1 11/11/25, 10:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88973
-
Torben Hansen uploaded patch set 10
V +111/11/25, 17:28 -
core-ci voted on patch set 10 V +1 11/11/25, 17:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89042
-
Simon Schaufelberger commented on patch set 10 01/23/26, 17:22
@derhansen@gmail.com I would love this one in v14. I personally use a lot of dirty hacks in my own projects for this. Do you think you can finish it? -
Torben Hansen commented on patch set 10 01/23/26, 17:26
Reply Unresolved
The patch is not compete from a security perspective and will need more work and most likely also a different concept. See my comment in https://forge.typo3.org/issues/107002 -
Simon Schaufelberger commented on patch set 10 02/22/26, 17:09
Unresolved
Add: Resolves: #102567 as well