89942[BUGFIX] add aria-invalid Attribut to fields with has-error class in form-engin-validation.
Commit message
Review
-
Code review CR -1
- Andreas Kienast -1
- Mathias Brodala -1
-
Verified V 0
- core-ci +1 CI
Issues 1
Files 2
Review log 45
-
Christian Rath-Ulrich uploaded patch set 1 06/30/25, 07:17
-
Mathias Brodala commented on patch set 1 CR -1 06/30/25, 07:22
form-engine-validation.ts:479Either the commit message is wrong or this is unrelated. In that case the change suggested by the commit message is missing. -
core-ci voted on patch set 1 V +1 06/30/25, 07:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81138
-
Andreas Kienast commented on patch set 1 CR -1 06/30/25, 07:38
form-engine-validation.ts:479Reply UnresolvedThis looks like the code was not properly rebased. There was a breaking change lately that removed this exact `eval`. -
Christian Rath-Ulrich abandoned the change 06/30/25, 07:57
false rebase
form-engine-validation.ts:30Unresolved