Review main Abandoned

89942[BUGFIX] add aria-invalid Attribut to fields with has-error class in form-engin-validation.

Christian Rath-Ulrich CR -1 V 0 Easy +17 −8 updated 06/30/25, 07:57

Commit message

Review

  • Code review CR -1
    • Andreas Kienast -1
    • Mathias Brodala -1
  • Verified V 0
    • core-ci +1 CI

Issues 1

Files 2

Review log 45

  1. Christian Rath-Ulrich uploaded patch set 1 06/30/25, 07:17

  2. Mathias Brodala commented on patch set 1 CR -1 06/30/25, 07:22

    form-engine-validation.ts:30 Unresolved

    Too many changes?

    form-engine-validation.ts:479

    Either the commit message is wrong or this is unrelated. In that case the change suggested by the commit message is missing.
  3. core-ci voted on patch set 1 V +1 06/30/25, 07:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81138

  4. Andreas Kienast commented on patch set 1 CR -1 06/30/25, 07:38

    form-engine-validation.ts:479 Reply Unresolved

    This looks like the code was not properly rebased. There was a breaking change lately that removed this exact `eval`.
  5. Christian Rath-Ulrich abandoned the change 06/30/25, 07:57

    false rebase