89943[TASK] Improve a11y with aria-invalid attributes on FormEngine fields
Commit message
Review
-
Code review CR +2 Done
- Benjamin Kott +2
- Georg Ringer +1
- Jörg Bösche +1
- Andreas Kienast +1
- Mathias Brodala +1
-
Verified V +2 Done
- Benjamin Kott +2
- Georg Ringer +1
- Andreas Kienast +1
- core-ci +1 CI
Issues 1
Files 2
Review log 1419
-
Christian Rath-Ulrich uploaded patch set 1 06/30/25, 07:55
-
core-ci voted on patch set 1 V +1 06/30/25, 08:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81139
-
Christian Rath-Ulrich uploaded patch set 2
V +106/30/25, 08:04 -
core-ci voted on patch set 2 V +1 06/30/25, 08:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81140
-
Christian Rath-Ulrich updated the commit message in patch set 3
V +106/30/25, 08:17 -
core-ci voted on patch set 3 V +1 06/30/25, 08:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81141
-
Oliver Klee updated the commit message in patch set 4
V +106/30/25, 13:02 -
core-ci voted on patch set 4 V +1 06/30/25, 13:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81143
-
Garvin Hicking updated the commit message in patch set 5
V +106/30/25, 13:10 -
core-ci voted on patch set 5 V +1 06/30/25, 13:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81144
-
Jörg Bösche voted on patch set 5 CR +1 08/18/25, 11:27
-
Mathias Brodala commented on patch set 5 09/04/25, 07:15
-
Christian Rath-Ulrich commented on patch set 5 09/04/25, 20:10
form-engine-validation.ts:363ReplyYou are right, but then get an error when building the js Sources/TypeScript/backend/form-engine-validation.ts:363:40 - error TS2345: Argument of type 'boolean' is not assignable to parameter of type 'string'. 363 field.setAttribute('aria-invalid', markParent); ~~~~~~~~~~ Found 1 error in Sources/TypeScript/backend/form-engine-validation.ts:363 -
Georg Ringer voted on patch set 5 CR +1 V +1 09/05/25, 04:48
-
Mathias Brodala commented on patch set 5 CR +1 09/05/25, 06:50
form-engine-validation.ts:363ReplyInteresting. Then better keep it as is, it won't hurt. -
Benjamin Kott voted on patch set 5 CR +2 V +2 09/09/25, 09:16
-
Andreas Kienast voted on patch set 5 CR +1 09/09/25, 09:18
-
Andreas Kienast voted on patch set 5 V +1 09/09/25, 10:44
-
Benjamin Kott merged patch set 6 09/09/25, 10:49
form-engine-validation.ts:363