Review main Merged

89943[TASK] Improve a11y with aria-invalid attributes on FormEngine fields

Christian Rath-Ulrich CR +2 V +2 Easy +2 −1 updated 09/09/25, 10:49

Commit message

With this patch, fields rendered in FormEngine are now marked with
an "aria-invalid=true|false" HTML-tag attribute to improve accessibility.

Review

  • Code review CR +2 Done
    • Benjamin Kott +2
    • Georg Ringer +1
    • Jörg Bösche +1
    • Andreas Kienast +1
    • Mathias Brodala +1
  • Verified V +2 Done
    • Benjamin Kott +2
    • Georg Ringer +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1419

  1. Christian Rath-Ulrich uploaded patch set 1 06/30/25, 07:55

  2. core-ci voted on patch set 1 V +1 06/30/25, 08:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81139

  3. Christian Rath-Ulrich uploaded patch set 2 V +1 06/30/25, 08:04

  4. core-ci voted on patch set 2 V +1 06/30/25, 08:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81140

  5. Christian Rath-Ulrich updated the commit message in patch set 3 V +1 06/30/25, 08:17

  6. core-ci voted on patch set 3 V +1 06/30/25, 08:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81141

  7. Oliver Klee updated the commit message in patch set 4 V +1 06/30/25, 13:02

  8. core-ci voted on patch set 4 V +1 06/30/25, 13:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81143

  9. Garvin Hicking updated the commit message in patch set 5 V +1 06/30/25, 13:10

  10. core-ci voted on patch set 5 V +1 06/30/25, 13:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81144

  11. Jörg Bösche voted on patch set 5 CR +1 08/18/25, 11:27

  12. Mathias Brodala commented on patch set 5 09/04/25, 07:15

    form-engine-validation.ts:363

    This is not necessary: > Any non-string value specified is converted automatically into a string. See https://developer.mozilla.org/en-US/docs/Web/API/Element/setAttribute
  13. Christian Rath-Ulrich commented on patch set 5 09/04/25, 20:10

    form-engine-validation.ts:363 Reply

    You are right, but then get an error when building the js Sources/TypeScript/backend/form-engine-validation.ts:363:40 - error TS2345: Argument of type 'boolean' is not assignable to parameter of type 'string'. 363 field.setAttribute('aria-invalid', markParent); ~~~~~~~~~~ Found 1 error in Sources/TypeScript/backend/form-engine-validation.ts:363
  14. Georg Ringer voted on patch set 5 CR +1 V +1 09/05/25, 04:48

  15. Mathias Brodala commented on patch set 5 CR +1 09/05/25, 06:50

    form-engine-validation.ts:363 Reply

    Interesting. Then better keep it as is, it won't hurt.
  16. Benjamin Kott voted on patch set 5 CR +2 V +2 09/09/25, 09:16

  17. Andreas Kienast voted on patch set 5 CR +1 09/09/25, 09:18

  18. Andreas Kienast voted on patch set 5 V +1 09/09/25, 10:44

  19. Benjamin Kott merged patch set 6 09/09/25, 10:49