Review main Merged

89945[BUGFIX] Render inline indent in workspace module

Christian Kuhn CR +2 V +2 Easy +6 −1 updated 07/01/25, 09:38

Commit message

This got lost with #102432: Inline children should have
an indent to be better visible in workspace BE module.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Jasmina Ließmann +1
    • Andreas Nedbal +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Jasmina Ließmann +1
    • Andreas Nedbal +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 89

  1. Christian Kuhn uploaded patch set 1 06/30/25, 16:24

  2. core-ci voted on patch set 1 V +1 06/30/25, 16:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81145

  3. Andreas Nedbal voted on patch set 1 CR +1 V +1 06/30/25, 16:31

  4. Jasmina Ließmann voted on patch set 1 CR +1 V +1 06/30/25, 16:43

  5. Andreas Kienast commented on patch set 1 CR +1 V +1 07/01/25, 05:27

    record-table.ts:231

    Checking this is no hard requirement as `indent` supports its `level` being 0, but no hard blocker for me.
  6. Christian Kuhn commented on patch set 1 07/01/25, 07:44

    record-table.ts:231 Reply

    ah, i was unaware of this. but does not matter much, i guess we could just keep it, or i improve the line with one of the next changes.
  7. Christian Kuhn voted on patch set 1 CR +2 V +2 07/01/25, 07:44

  8. Christian Kuhn merged patch set 2 07/01/25, 07:44

  9. Christian Kuhn commented on patch set 2 07/01/25, 09:38

    record-table.ts:231 Reply

    i'm keeping the check for now: having that span with level 0 still indents some pixel.