Review main Merged

89952[BUGFIX] Use distinct XLF label for MIME-Type error message

Garvin Hicking CR +2 V +2 Easy +2 −2 updated 07/01/25, 17:44

Commit message

The patch in #106916 introduced a new argument to the existing
XLF key "FileUtility.MimeTypeNotAllowedForFileExtension".

Translation servers already deliver this translated key, which
raises PHP exception messages for TYPO3 versions that do not
specify this argument yet (no releases with this patch had been
made yet).

This patch resolves this situation by introducing a new label
key, which should have been done in first place.

The "tainted" key is now removed, which should lead to these
scenarios, where "MimeTypeNotAllowedForFileExtension=OldLabel"
and MimeTypeNotAllowedForFileExtensionWithExpectation=NewLabel"
once this patch is merged:

1) Old TYPO3 with current translation:
- PHP errors (until translation is rolled back)

2) Old TYPO3 with updated translation:
- No PHP errors
- Once OldLabel is removed in translation, message will show
  up in english instead of local language.

3) Old TYPO3 with outdated translation (older than last week)
- No PHP errors
- Localized display
- Once OldLabel is removed in translation, message will show
  up in english instead of local language.

4) Updated TYPO3 next week with current translation
- No PHP errors
- Once NewLabel is added in translations, message will show
  up in local language. Until then, english fallback.
- OldLabel has no relevance

5) Updated TYPO3 with updated translation
- No PHP errors
- Localized display
- OldLabel has no relevance

6) Updated TYPO3 with outdated translation
- No PHP errors
- Message will show up in english message.
- Needs language update so that translation will show up,
  if NewLabel was added meanwhile.
- OldLabel has no relevance

The contribution docs [1] will be updated to reflect the need for
not adding arguments to existing keys.

[1] https://github.com/TYPO3-Documentation/TYPO3CMS-Guide-ContributionWorkflow/pull/386

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
    • Oliver Klee +1
    • Christian Kuhn +1
    • Peter Kraume +1
  • Verified V +2 Done
    • Garvin Hicking +2
    • Christian Kuhn +1
    • Peter Kraume +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 1318

  1. Garvin Hicking uploaded patch set 1 07/01/25, 08:31

  2. core-ci voted on patch set 1 V +1 07/01/25, 08:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81168

  3. Garvin Hicking updated the commit message in patch set 2 V +1 07/01/25, 09:19

  4. core-ci voted on patch set 2 V +1 07/01/25, 09:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81169

  5. Oliver Klee voted on patch set 2 CR +1 07/01/25, 10:04

  6. Garvin Hicking updated the commit message in patch set 3 CR +1 V +1 07/01/25, 11:07

  7. Garvin Hicking commented on patch set 4 07/01/25, 11:08

    Published edit on patch set 3.
  8. core-ci voted on patch set 4 V +1 07/01/25, 11:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81179

  9. core-ci voted on patch set 3 V +1 07/01/25, 11:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81178

  10. Christian Kuhn voted on patch set 4 CR +1 V +1 07/01/25, 11:48

  11. Peter Kraume voted on patch set 4 CR +1 V +1 07/01/25, 12:07

  12. Garvin Hicking updated the commit message in patch set 5 CR +1 V +1 07/01/25, 13:45

  13. Oliver Klee voted on patch set 5 CR +1 07/01/25, 13:45

  14. Peter Kraume voted on patch set 5 CR +1 V +1 07/01/25, 13:51

  15. core-ci voted on patch set 5 V +1 07/01/25, 13:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81191

  16. Christian Kuhn voted on patch set 5 CR +1 V +1 07/01/25, 15:21

  17. Garvin Hicking voted on patch set 5 CR +2 V +2 07/01/25, 17:27

  18. Garvin Hicking merged patch set 6 07/01/25, 17:44