Review main Merged

89956[TASK] Require and use dependency injection in database services

Benjamin Franzke CR +2 V +2 Expert +647 −710 updated 07/10/26, 06:31

Commit message

Allow for clean TCA Schema usage, whose factory requires the
symfony container to be used, therefore we now limit ourselves
to only use the database connection on a fully booted system
and not in a failsafe environment.

This allows to drop workarounds we added with #106867 and
allows to rely on dependency injection and avoid `GU::makeInstance`
in database related services or restrictions.

The consequence is that all usages of the connection pool inside
the install tool now ensures to boot into the symfony container
in order to provide the requirements that are now needed for the
connection pool to run. This is a continuation of the efforts
started in #110128 in order to reduce failsafe provided services
into those that are actually needed for failsafe operation (which
is to recover from a broken installation).

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Andreas Kienast +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Andreas Kienast +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 4

Files 65

Show 45 more files

Review log 4373

Show 2548 earlier messages
  1. Benjamin Franzke uploaded patch set 1 07/01/25, 10:39

  2. core-ci voted on patch set 1 V -1 07/01/25, 10:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81176

  3. Benjamin Franzke uploaded patch set 2 V -1 07/02/25, 06:59

  4. core-ci voted on patch set 2 V -1 07/02/25, 07:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81233

  5. Benjamin Franzke uploaded patch set 3 V -1 06/24/26, 08:20

  6. core-ci voted on patch set 3 V -1 06/24/26, 08:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103799

  7. Benjamin Franzke uploaded patch set 4 V -1 06/25/26, 10:38

  8. core-ci voted on patch set 4 V -1 06/25/26, 10:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103872

  9. Benjamin Franzke uploaded patch set 5 V -1 06/25/26, 11:06

  10. core-ci voted on patch set 5 V -1 06/25/26, 11:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103873

  11. Benjamin Franzke uploaded patch set 6 V -1 06/25/26, 11:56

  12. core-ci voted on patch set 6 V -1 06/25/26, 12:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103875

  13. Benjamin Franzke uploaded patch set 7 V -1 07/06/26, 07:31

  14. core-ci voted on patch set 7 V -1 07/06/26, 07:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104385

  15. core-ci commented on patch set 7 07/06/26, 08:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104385

  16. Benjamin Franzke uploaded patch set 8 V -1 07/06/26, 09:18

  17. core-ci voted on patch set 8 V -1 07/06/26, 09:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104394

  18. Benjamin Franzke uploaded patch set 9 V -1 07/06/26, 11:51

  19. core-ci voted on patch set 9 V -1 07/06/26, 12:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104401

  20. Benjamin Franzke uploaded patch set 10 V -1 07/06/26, 14:45

  21. core-ci voted on patch set 10 V -1 07/06/26, 14:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104409

  22. Benjamin Franzke uploaded patch set 11 V -1 07/06/26, 15:44

  23. core-ci voted on patch set 11 V -1 07/06/26, 15:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104414

  24. Benjamin Franzke uploaded patch set 12 V -1 07/06/26, 16:14

  25. core-ci voted on patch set 12 V -1 07/06/26, 16:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104415

  26. Benjamin Franzke uploaded patch set 13 V -1 07/06/26, 17:15

  27. core-ci voted on patch set 13 V -1 07/06/26, 17:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104416

  28. Benjamin Franzke uploaded patch set 14 V -1 07/06/26, 17:29

  29. Benjamin Franzke uploaded patch set 15 07/06/26, 17:36

  30. core-ci voted on patch set 14 V -1 07/06/26, 17:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104417

  31. core-ci voted on patch set 15 V -1 07/06/26, 17:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104418

  32. Benjamin Franzke uploaded patch set 16 V -1 07/06/26, 18:01

  33. core-ci voted on patch set 16 V -1 07/06/26, 18:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104420

  34. Benjamin Franzke uploaded patch set 17 V -1 07/06/26, 18:44

  35. core-ci voted on patch set 17 V -1 07/06/26, 18:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104422

  36. Benjamin Franzke uploaded patch set 18 V -1 07/07/26, 06:24

  37. core-ci voted on patch set 18 V -1 07/07/26, 06:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104436

  38. Benjamin Franzke uploaded patch set 19 V -1 07/07/26, 07:14

  39. core-ci voted on patch set 19 V +1 07/07/26, 07:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104441

  40. Benjamin Franzke updated the commit message in patch set 20 V +1 07/07/26, 09:18

  41. core-ci voted on patch set 20 V +1 07/07/26, 09:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104451

  42. Andreas Kienast uploaded patch set 21 V +1 07/07/26, 10:50

  43. Andreas Kienast commented on patch set 21 07/07/26, 10:51

    SessionService.php:278

    Why do we need a variable here?
  44. core-ci voted on patch set 21 V -1 07/07/26, 10:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104458

  45. Andreas Kienast commented on patch set 21 07/07/26, 11:08

    Connection.php:100

    This doesn't work, phpstan is not happy...
  46. Andreas Kienast uploaded patch set 22 V -1 07/07/26, 11:08

  47. core-ci voted on patch set 22 V +1 07/07/26, 11:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104459

  48. Benjamin Franzke commented on patch set 22 07/07/26, 13:06

    SessionService.php:278 Reply

    I used it for descriptiveness, because our policy does not allow named arguments here. Maybe I should put the `true` on a single line instead and apply the comment to that single intended line?
  1. Benjamin Franzke uploaded patch set 23 V +1 07/07/26, 13:08

  2. Benjamin Franzke commented on patch set 23 07/07/26, 13:09

    SessionService.php:278 Reply

    Applied that, fine with you?
  3. Benjamin Franzke commented on patch set 23 07/07/26, 13:10

    Connection.php:100 Reply

    Declaring the derived `Configuration` type would have been nice indeed. I actually didn't know phpstan complains about that and it was a leftover from my side, because I initially wanted to make it optional. Anyway, I'll keep this in mind, maybe phpstan "opinion" changes on that… Thx anyway for trying to improve this!
  4. core-ci voted on patch set 23 V +1 07/07/26, 13:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104470

  5. Benjamin Franzke uploaded patch set 24 V +1 07/07/26, 14:30

  6. Benjamin Franzke uploaded patch set 25 07/07/26, 14:31

  7. core-ci voted on patch set 24 V -1 07/07/26, 14:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104474

  8. core-ci voted on patch set 25 V +1 07/07/26, 14:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104475

  9. Andreas Kienast commented on patch set 25 07/08/26, 08:42

    SessionService.php:278 Reply

    Acknowledged
  10. Andreas Kienast commented on patch set 26 V +1 07/08/26, 08:43

    Published edit on patch set 25.
  11. core-ci voted on patch set 26 V +1 07/08/26, 08:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104508

  12. Andreas Kienast commented on patch set 26 07/08/26, 13:25

    SetupService.php:240

    "persistence of changed" what? Or is this a typo of "changes"?
  13. Andreas Kienast commented on patch set 26 V -1 07/08/26, 14:24

    Adding or removing a language in the Install Tool via Maintenance -> Manage Language Packs fails: ``` Too few arguments to function TYPO3\CMS\Core\Registry::__construct(), 0 passed in /var/www/html/typo3_src/typo3/sysext/core/Classes/Utility/GeneralUtility.php on line 2489 and exactly 2 expected ```
  14. Benjamin Franzke uploaded patch set 27 V +1 07/09/26, 07:57

  15. Benjamin Franzke commented on patch set 27 07/09/26, 07:57

    Reply

    Thanks for catching this. Fixed now 😊

    SetupService.php:240 Reply

    Yes, typo. Fixed, thanks!
  16. core-ci voted on patch set 27 V -1 07/09/26, 08:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104561

  17. core-ci voted on patch set 27 V +1 07/09/26, 08:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104561

  18. Simon Schaufelberger commented on patch set 27 07/09/26, 10:32

    DefaultTcaSchema.php:73

    can be readonly, or?
  19. Benjamin Franzke uploaded patch set 28 V +1 07/09/26, 11:19

  20. Benjamin Franzke commented on patch set 28 07/09/26, 11:19

    DefaultTcaSchema.php:73 Reply

    ack, done. Thx!
  21. Andreas Kienast voted on patch set 28 CR +1 V +1 07/09/26, 11:21

  22. core-ci voted on patch set 28 V +1 07/09/26, 11:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104564

  23. Simon Schaufelberger voted on patch set 28 CR +1 V +1 07/09/26, 11:43

  24. Benjamin Franzke voted on patch set 28 CR +2 V +2 07/10/26, 06:30

  25. Benjamin Franzke merged patch set 29 07/10/26, 06:31