89956[TASK] Require and use dependency injection in database services
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
- Andreas Kienast +1
- Simon Schaufelberger +1
-
Verified V +2 Done
- Benjamin Franzke +2
- Andreas Kienast +1
- Simon Schaufelberger +1
- core-ci +1 CI
Issues 4
Files 65
- typo3/sysext/backend/Tests/Functional/Authentication/PasswordResetTest.php+5 −5
- typo3/sysext/core/Classes/Command/CacheFlushTagsCommand.php+6 −7
- typo3/sysext/core/Classes/Command/UpgradeWizardRunCommand.php+5 −4
- typo3/sysext/core/Classes/Core/BootService.php+5 −0
- typo3/sysext/core/Classes/Database/Query/Expression/ExpressionBuilder.php+10 −2
- typo3/sysext/core/Classes/Database/Query/Restriction/DeletedRestriction.php+3 −10
- typo3/sysext/core/Classes/Database/Query/Restriction/EmptyRestrictionContainer.phpdeleted+0 −20
- typo3/sysext/core/Classes/Database/Query/Restriction/EndTimeRestriction.php+3 −6
- typo3/sysext/core/Classes/Database/Query/Restriction/FrontendGroupRestriction.php+3 −4
- typo3/sysext/core/Classes/Database/Query/Restriction/HiddenRestriction.php+3 −10
- typo3/sysext/core/Classes/Database/Query/Restriction/StartTimeRestriction.php+3 −6
- typo3/sysext/core/Classes/Database/Query/Restriction/WorkspaceRestriction.php+2 −5
- typo3/sysext/core/Classes/Database/Query/QueryBuilder.php+1 −1
- typo3/sysext/core/Classes/Database/Schema/Parser/TableBuilder.php+1 −2
- typo3/sysext/core/Classes/Database/Schema/ConnectionMigrator.php+5 −18
- typo3/sysext/core/Classes/Database/Schema/DefaultTcaSchema.php2+5 −6
- typo3/sysext/core/Classes/Database/Schema/SchemaMigrator.php+3 −3
- typo3/sysext/core/Classes/Database/Configuration.phpnew+37 −0
- typo3/sysext/core/Classes/Database/Connection.php2+8 −7
- typo3/sysext/core/Classes/Database/ConnectionPool.php+30 −30
Show 45 more files
- typo3/sysext/core/Classes/FormProtection/FormProtectionFactory.php+4 −3
- typo3/sysext/core/Classes/Localization/LanguagePackService.php+13 −21
- typo3/sysext/core/Classes/Package/FailsafePackageManager.php+7 −16
- typo3/sysext/core/Classes/Package/PackageManager.php+23 −0
- typo3/sysext/core/Classes/Service/DatabaseUpgradeWizardsService.php+16 −16
- typo3/sysext/core/Classes/Session/Backend/DatabaseSessionBackend.php+7 −1
- typo3/sysext/core/Classes/Session/SessionManager.php+8 −1
- typo3/sysext/core/Classes/Upgrades/DatabaseUpdatedPrerequisite.php+3 −5
- typo3/sysext/core/Classes/Registry.php+8 −7
- typo3/sysext/core/Classes/ServiceProvider.php+7 −64
- typo3/sysext/core/Tests/Functional/Database/Query/Restriction/AbstractRestrictionTestCase.php+2 −1
- typo3/sysext/core/Tests/Functional/Session/Backend/DatabaseSessionBackendTest.php+1 −1
- typo3/sysext/core/Tests/Functional/Session/SessionManagerTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Authentication/BackendUserAuthenticationTest.php+12 −3
- typo3/sysext/core/Tests/Unit/Database/Query/Expression/ExpressionBuilderTest.php+6 −4
- typo3/sysext/core/Tests/Unit/Database/Query/QueryBuilderTest.php+53 −53
- typo3/sysext/core/Tests/Unit/Database/Schema/ConnectionMigratorTest.php+4 −1
- typo3/sysext/core/Tests/Unit/Database/Schema/DefaultTcaSchemaTest.php+109 −109
- typo3/sysext/core/Tests/Unit/Database/ConnectionTest.php+20 −13
- typo3/sysext/core/Tests/Unit/Domain/Event/ModifyDefaultConstraintsForDatabaseQueryEventTest.php+3 −2
- typo3/sysext/core/Tests/Unit/FormProtection/FormProtectionFactoryTest.php+8 −2
- typo3/sysext/core/Tests/Unit/Session/Backend/DatabaseSessionBackendTest.php+2 −1
- typo3/sysext/core/Tests/Unit/Session/SessionManagerTest.php+3 −2
- typo3/sysext/core/Tests/Unit/RegistryTest.php+10 −6
- typo3/sysext/frontend/Tests/Unit/ContentObject/Menu/AbstractMenuContentObjectTest.php+3 −1
- typo3/sysext/install/Classes/Controller/BackendModuleController.php+6 −2
- typo3/sysext/install/Classes/Controller/EnvironmentController.php+5 −3
- typo3/sysext/install/Classes/Controller/InstallerController.php+7 −5
- typo3/sysext/install/Classes/Controller/MaintenanceController.php+17 −8
- typo3/sysext/install/Classes/Controller/SettingsController.php+7 −2
- typo3/sysext/install/Classes/Controller/UpgradeController.php+20 −11
- typo3/sysext/install/Classes/Service/ClearCacheService.php+14 −18
- typo3/sysext/install/Classes/Service/ClearTableService.php+9 −5
- typo3/sysext/install/Classes/Service/SessionService.php4+18 −13
- typo3/sysext/install/Classes/Service/SetupDatabaseService.php+2 −1
- typo3/sysext/install/Classes/Service/SetupService.php2+32 −27
- typo3/sysext/install/Classes/SystemEnvironment/DatabaseCheck/Platform/AbstractPlatform.php+4 −2
- typo3/sysext/install/Classes/SystemEnvironment/DatabaseCheck/Platform/MySql.php+1 −2
- typo3/sysext/install/Classes/SystemEnvironment/DatabaseCheck/Platform/PostgreSql.php+1 −2
- typo3/sysext/install/Classes/SystemEnvironment/DatabaseCheck/Platform/Sqlite.php+1 −2
- typo3/sysext/install/Classes/SystemEnvironment/DatabaseCheck.php+10 −3
- typo3/sysext/install/Classes/ServiceProvider.php+10 −23
- typo3/sysext/install/Tests/Functional/Service/SetupServiceTest.php+10 −65
- typo3/sysext/install/Tests/Unit/Service/ClearTableServiceTest.phpdeleted+0 −35
- typo3/sysext/install/Tests/Unit/SystemEnvironment/DatabaseCheck/Platform/MySqlTest.php+2 −1
Review log 4373
Show 2548 earlier messages
-
Benjamin Franzke uploaded patch set 1 07/01/25, 10:39
-
core-ci voted on patch set 1 V -1 07/01/25, 10:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81176
-
Benjamin Franzke uploaded patch set 2
V -107/02/25, 06:59 -
core-ci voted on patch set 2 V -1 07/02/25, 07:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81233
-
Benjamin Franzke uploaded patch set 3
V -106/24/26, 08:20 -
core-ci voted on patch set 3 V -1 06/24/26, 08:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103799
-
Benjamin Franzke uploaded patch set 4
V -106/25/26, 10:38 -
core-ci voted on patch set 4 V -1 06/25/26, 10:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103872
-
Benjamin Franzke uploaded patch set 5
V -106/25/26, 11:06 -
core-ci voted on patch set 5 V -1 06/25/26, 11:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103873
-
Benjamin Franzke uploaded patch set 6
V -106/25/26, 11:56 -
core-ci voted on patch set 6 V -1 06/25/26, 12:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103875
-
Benjamin Franzke uploaded patch set 7
V -107/06/26, 07:31 -
core-ci voted on patch set 7 V -1 07/06/26, 07:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104385
-
core-ci commented on patch set 7 07/06/26, 08:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104385
-
Benjamin Franzke uploaded patch set 8
V -107/06/26, 09:18 -
core-ci voted on patch set 8 V -1 07/06/26, 09:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104394
-
Benjamin Franzke uploaded patch set 9
V -107/06/26, 11:51 -
core-ci voted on patch set 9 V -1 07/06/26, 12:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104401
-
Benjamin Franzke uploaded patch set 10
V -107/06/26, 14:45 -
core-ci voted on patch set 10 V -1 07/06/26, 14:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104409
-
Benjamin Franzke uploaded patch set 11
V -107/06/26, 15:44 -
core-ci voted on patch set 11 V -1 07/06/26, 15:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104414
-
Benjamin Franzke uploaded patch set 12
V -107/06/26, 16:14 -
core-ci voted on patch set 12 V -1 07/06/26, 16:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104415
-
Benjamin Franzke uploaded patch set 13
V -107/06/26, 17:15 -
core-ci voted on patch set 13 V -1 07/06/26, 17:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104416
-
Benjamin Franzke uploaded patch set 14
V -107/06/26, 17:29 -
Benjamin Franzke uploaded patch set 15 07/06/26, 17:36
-
core-ci voted on patch set 14 V -1 07/06/26, 17:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104417
-
core-ci voted on patch set 15 V -1 07/06/26, 17:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104418
-
Benjamin Franzke uploaded patch set 16
V -107/06/26, 18:01 -
core-ci voted on patch set 16 V -1 07/06/26, 18:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104420
-
Benjamin Franzke uploaded patch set 17
V -107/06/26, 18:44 -
core-ci voted on patch set 17 V -1 07/06/26, 18:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104422
-
Benjamin Franzke uploaded patch set 18
V -107/07/26, 06:24 -
core-ci voted on patch set 18 V -1 07/07/26, 06:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104436
-
Benjamin Franzke uploaded patch set 19
V -107/07/26, 07:14 -
core-ci voted on patch set 19 V +1 07/07/26, 07:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104441
-
Benjamin Franzke updated the commit message in patch set 20
V +107/07/26, 09:18 -
core-ci voted on patch set 20 V +1 07/07/26, 09:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104451
-
Andreas Kienast uploaded patch set 21
V +107/07/26, 10:50 -
Andreas Kienast commented on patch set 21 07/07/26, 10:51
-
core-ci voted on patch set 21 V -1 07/07/26, 10:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104458
-
Andreas Kienast commented on patch set 21 07/07/26, 11:08
Connection.php:100This doesn't work, phpstan is not happy... -
Andreas Kienast uploaded patch set 22
V -107/07/26, 11:08 -
core-ci voted on patch set 22 V +1 07/07/26, 11:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104459
-
Benjamin Franzke commented on patch set 22 07/07/26, 13:06
SessionService.php:278ReplyI used it for descriptiveness, because our policy does not allow named arguments here. Maybe I should put the `true` on a single line instead and apply the comment to that single intended line?
-
Benjamin Franzke uploaded patch set 23
V +107/07/26, 13:08 -
Benjamin Franzke commented on patch set 23 07/07/26, 13:09
SessionService.php:278ReplyApplied that, fine with you? -
Benjamin Franzke commented on patch set 23 07/07/26, 13:10
Connection.php:100ReplyDeclaring the derived `Configuration` type would have been nice indeed. I actually didn't know phpstan complains about that and it was a leftover from my side, because I initially wanted to make it optional. Anyway, I'll keep this in mind, maybe phpstan "opinion" changes on that… Thx anyway for trying to improve this! -
core-ci voted on patch set 23 V +1 07/07/26, 13:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104470
-
Benjamin Franzke uploaded patch set 24
V +107/07/26, 14:30 -
Benjamin Franzke uploaded patch set 25 07/07/26, 14:31
-
core-ci voted on patch set 24 V -1 07/07/26, 14:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104474
-
core-ci voted on patch set 25 V +1 07/07/26, 14:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104475
-
Andreas Kienast commented on patch set 25 07/08/26, 08:42
SessionService.php:278ReplyAcknowledged -
Andreas Kienast commented on patch set 26
V +107/08/26, 08:43Published edit on patch set 25. -
core-ci voted on patch set 26 V +1 07/08/26, 08:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104508
-
Andreas Kienast commented on patch set 26 07/08/26, 13:25
SetupService.php:240"persistence of changed" what? Or is this a typo of "changes"? -
Andreas Kienast commented on patch set 26 V -1 07/08/26, 14:24
Adding or removing a language in the Install Tool via Maintenance -> Manage Language Packs fails: ``` Too few arguments to function TYPO3\CMS\Core\Registry::__construct(), 0 passed in /var/www/html/typo3_src/typo3/sysext/core/Classes/Utility/GeneralUtility.php on line 2489 and exactly 2 expected ``` -
Benjamin Franzke uploaded patch set 27
V +107/09/26, 07:57 -
Benjamin Franzke commented on patch set 27 07/09/26, 07:57
Reply
Thanks for catching this. Fixed now 😊SetupService.php:240ReplyYes, typo. Fixed, thanks! -
core-ci voted on patch set 27 V -1 07/09/26, 08:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104561
-
core-ci voted on patch set 27 V +1 07/09/26, 08:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104561
-
Simon Schaufelberger commented on patch set 27 07/09/26, 10:32
DefaultTcaSchema.php:73can be readonly, or? -
Benjamin Franzke uploaded patch set 28
V +107/09/26, 11:19 -
Benjamin Franzke commented on patch set 28 07/09/26, 11:19
DefaultTcaSchema.php:73Replyack, done. Thx! -
Andreas Kienast voted on patch set 28 CR +1 V +1 07/09/26, 11:21
-
core-ci voted on patch set 28 V +1 07/09/26, 11:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104564
-
Simon Schaufelberger voted on patch set 28 CR +1 V +1 07/09/26, 11:43
-
Benjamin Franzke voted on patch set 28 CR +2 V +2 07/10/26, 06:30
-
Benjamin Franzke merged patch set 29 07/10/26, 06:31
SessionService.php:278