Review main Merged

89960[BUGFIX] Allow recursive restore of records via recylcer for editors

Benjamin Franzke CR +2 V +2 Normal +23 −31 updated 07/02/25, 10:44

Commit message

The current approach to lookup deleted records in the recycler module
is to apply a fragile runtime TCA modification that effectively removes
the `delete` ctrl from pages in order to make rootline based
`isInWebMount` checks work.

This works in most cases, but there are corner cases where recursive
records are checked, and `BackendUserAuthentication::isInWebMount`
uses `BackendUtility::getPageForRootline` to obtain a rootline
both for deleted content elements and for pages, but it does only
apply the TCA modification when processing pages, not when checking
content elements. This results in an invalid (runtime) rootline cache
being generated/used when creating the list of deleted pages *and*
content elements.

Instead of faking TCA (which will require schema rebuilds once we
migrate to TCA schema) or extending the rootline cache to hash current
schema/TCA  the relevant access checking methods now learn to ignore the
delete-restriction instead of invalidly and globally modifying TCA.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Stefan Bürk +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Stefan Bürk +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 4

Review log 1217

  1. Benjamin Franzke uploaded patch set 1 07/01/25, 12:01

  2. core-ci voted on patch set 1 V -1 07/01/25, 12:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81185

  3. Benjamin Franzke uploaded patch set 2 V -1 07/01/25, 12:15

  4. core-ci voted on patch set 2 V -1 07/01/25, 12:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81186

  5. Benjamin Franzke uploaded patch set 3 V -1 07/01/25, 12:26

  6. core-ci voted on patch set 3 V -1 07/01/25, 12:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81188

  7. Benjamin Franzke uploaded patch set 4 V -1 07/01/25, 12:42

  8. core-ci voted on patch set 4 V +1 07/01/25, 12:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81189

  9. Benjamin Franzke uploaded patch set 5 V +1 07/02/25, 06:18

  10. Benjamin Franzke marked it ready for review 07/02/25, 06:18

  11. Benjamin Franzke commented on patch set 5 07/02/25, 06:21

    I don't know why this issue is access restricted, but the relevant patch is https://review.typo3.org/c/Packages/TYPO3.CMS/+/45292
  12. core-ci voted on patch set 5 V +1 07/02/25, 06:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81230

  13. Stefan Bürk voted on patch set 5 CR +1 07/02/25, 08:43

  14. Stefan Bürk voted on patch set 5 V +1 07/02/25, 09:13

  15. Benni Mack commented on patch set 5 CR +1 V +1 07/02/25, 09:42

    tested in conjunction with the next patch in the Relation Chain.
  16. Oli Bartsch voted on patch set 5 CR +2 V +2 07/02/25, 10:44

  17. Oli Bartsch merged patch set 6 07/02/25, 10:44