Review main Merged

89962[TASK] Avoid unused workspace settings

Christian Kuhn CR +2 V +2 Normal +16 −47 updated 07/01/25, 17:26

Commit message

Further remnants from extjs:
* settings.Workspaces.States
* settings.Workspaces.SplitPreviewModes
* BE_USER->uc['moduleData']['Workspaces'][$workspace]['columns']
  Never written and surrounding code can be simplified

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Andreas Nedbal +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Andreas Nedbal +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 79

  1. Christian Kuhn uploaded patch set 1 07/01/25, 13:58

  2. Christian Kuhn voted on patch set 1 CR -1 07/01/25, 13:58

  3. core-ci voted on patch set 1 V +1 07/01/25, 14:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81192

  4. Christian Kuhn uploaded patch set 2 CR -1 V +1 07/01/25, 15:15

  5. core-ci voted on patch set 2 V +1 07/01/25, 15:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81194

  6. Benni Mack voted on patch set 2 CR +1 V +1 07/01/25, 15:27

  7. Andreas Nedbal voted on patch set 2 CR +1 V +1 07/01/25, 16:59

  8. Christian Kuhn voted on patch set 2 CR +2 V +2 07/01/25, 17:26

  9. Christian Kuhn merged patch set 3 07/01/25, 17:26