89967[TASK] Simplify workspace CommandMap class
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Stefan Bürk +1
- Benni Mack +1
-
Verified V +2 Done
- Christian Kuhn +2
- Stefan Bürk +1
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 5
- typo3/sysext/workspaces/Classes/DataHandler/CommandMap.php+166 −363
- typo3/sysext/workspaces/Classes/Dependency/DependencyResolver.php+1 −11
- typo3/sysext/workspaces/Classes/Dependency/ElementEntityProcessor.php+0 −15
- typo3/sysext/workspaces/Classes/Hook/DataHandlerHook.php+2 −1
- typo3/sysext/workspaces/Classes/Service/Dependency/CollectionService.php+7 −29
Review log 2850
Show 1325 earlier messages
-
Christian Kuhn uploaded patch set 1 07/01/25, 17:39
-
core-ci voted on patch set 1 V -1 07/01/25, 17:50 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81198
-
Christian Kuhn uploaded patch set 2
V -107/01/25, 18:52 -
Christian Kuhn uploaded patch set 3 07/01/25, 18:59
-
core-ci voted on patch set 2 V -1 07/01/25, 19:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81199
-
core-ci voted on patch set 3 V -1 07/01/25, 19:10 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81200
-
Christian Kuhn uploaded patch set 4
V -107/01/25, 21:37 -
core-ci voted on patch set 4 V +1 07/01/25, 21:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81204
-
Christian Kuhn uploaded patch set 5
V +107/01/25, 21:51 -
Christian Kuhn uploaded patch set 6 07/01/25, 22:01
-
core-ci voted on patch set 5 V +1 07/01/25, 22:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81205
-
core-ci voted on patch set 6 V +1 07/01/25, 22:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81206
-
Christian Kuhn uploaded patch set 7
V +107/01/25, 22:20 -
Christian Kuhn uploaded patch set 8 07/01/25, 22:26
-
core-ci voted on patch set 7 V +1 07/01/25, 22:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81207
-
core-ci voted on patch set 8 V +1 07/01/25, 22:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81208
-
Christian Kuhn uploaded patch set 9
V +107/01/25, 22:53 -
core-ci voted on patch set 9 V +1 07/01/25, 23:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81209
-
Christian Kuhn uploaded patch set 10
V +107/01/25, 23:26 -
core-ci voted on patch set 10 V +1 07/01/25, 23:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81210
-
Christian Kuhn uploaded patch set 11
V +107/01/25, 23:36 -
core-ci voted on patch set 11 V +1 07/01/25, 23:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81211
-
Christian Kuhn uploaded patch set 12
V +107/01/25, 23:45 -
core-ci voted on patch set 12 V +1 07/01/25, 23:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81212
-
Christian Kuhn uploaded patch set 13
V +107/01/25, 23:55
-
Christian Kuhn uploaded patch set 14 07/02/25, 00:00
-
core-ci voted on patch set 13 V +1 07/02/25, 00:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81213
-
core-ci voted on patch set 14 V +1 07/02/25, 00:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81214
-
Christian Kuhn uploaded patch set 15
V +107/02/25, 00:13 -
Christian Kuhn uploaded patch set 16 07/02/25, 00:16
-
Christian Kuhn uploaded patch set 17 07/02/25, 00:17
-
core-ci voted on patch set 15 V +1 07/02/25, 00:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81215
-
core-ci voted on patch set 16 V -1 07/02/25, 00:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81216
-
core-ci voted on patch set 17 V +1 07/02/25, 00:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81217
-
Christian Kuhn uploaded patch set 18
V +107/02/25, 07:57 -
core-ci voted on patch set 18 V +1 07/02/25, 08:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81234
-
Christian Kuhn uploaded patch set 19
V +107/02/25, 08:21 -
Christian Kuhn uploaded patch set 20 07/02/25, 08:23
-
core-ci voted on patch set 19 V +1 07/02/25, 08:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81235
-
core-ci voted on patch set 20 V +1 07/02/25, 08:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81236
-
Christian Kuhn uploaded patch set 21
V +107/02/25, 08:37 -
core-ci voted on patch set 21 V +1 07/02/25, 08:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81237
-
Christian Kuhn uploaded patch set 22
V +107/02/25, 09:18 -
Christian Kuhn commented on patch set 22 07/02/25, 09:19
Note the single patch sets reflect the entire refactoring process quite nicely: Nearly every patch set takes care of a single topic. -
core-ci voted on patch set 22 V +1 07/02/25, 09:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81239
-
Benni Mack voted on patch set 22 CR +1 V +1 07/02/25, 09:38
-
Stefan Bürk commented on patch set 22 CR -1 07/02/25, 12:23
Reviewing ... -
Stefan Bürk voted on patch set 22 CR +1 V +1 07/02/25, 14:34
-
Christian Kuhn voted on patch set 22 CR +2 V +2 07/02/25, 17:56
-
Christian Kuhn merged patch set 23 07/02/25, 17:56