Review 13.4 Merged

89970[BUGFIX] Handle preview image sizes as max values

Garvin Hicking CR +2 V +2 Easy +3 −3 updated 07/02/25, 11:39

Commit message

The given sizes of a preview image needs to be treated as a maximum
value to allow correct aspect ratio calculation. This is already covered
within the TYPO3\CMS\Core\Imaging\ImageProcessingInstructions but needs
to be adjusted within the actual LocalPreviewHelper as well.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
  • Verified V +2 Done
    • Garvin Hicking +2
    • core-ci +1 CI

Issues 3

Files 2

Review log 34

  1. Garvin Hicking commented on patch set 1 07/02/25, 10:59

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 07/02/25, 11:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81241

  3. Garvin Hicking voted on patch set 1 CR +2 V +2 07/02/25, 11:39

  4. Garvin Hicking merged patch set 2 07/02/25, 11:39