Review main Merged

89974[BUGFIX] Show proper line breaks in workspaces comment view

Benjamin Franzke CR +2 V +2 Easy +39 −8 updated 07/03/25, 10:10

Commit message

Also avoid double html-escaping values both on server
and client side. The jQuery to lit migration missed to
disable service-side htmlspecialchars, when lit was used
and threfore secure escaping has been applied in the
JavaScript renderer.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Christian Kuhn +1
    • Benni Mack +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Christian Kuhn +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 5

Review log 79

  1. Benjamin Franzke uploaded patch set 1 07/02/25, 14:33

  2. Benjamin Franzke uploaded patch set 2 07/02/25, 14:34

  3. core-ci voted on patch set 1 V -1 07/02/25, 14:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81248

  4. core-ci voted on patch set 2 V +1 07/02/25, 14:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81249

  5. Christian Kuhn commented on patch set 2 07/02/25, 14:57

    nice. thx. i'm working with the workspace BE module quite a bit lately and will give this one a testing shot soon.
  6. Christian Kuhn voted on patch set 2 CR +1 V +1 07/02/25, 21:04

  7. Benni Mack voted on patch set 2 CR +1 V +1 07/03/25, 09:52

  8. Benjamin Franzke voted on patch set 2 CR +2 V +2 07/03/25, 10:09

  9. Benjamin Franzke merged patch set 3 07/03/25, 10:10