Review 13.4 Merged

89975[TASK] Re-add legacy MimeTypeNotAllowedForFileExtension XLF label

Garvin Hicking CR +2 V +2 Easy +4 −0 updated 07/03/25, 10:59

Commit message

The TYPO3 localization server watches the 13.4 GIT branch for labels
that can be localized.

In earlier TYPO3 13.4 versions, the label
"MimeTypeNotAllowedForFileExtension" was needed and must only
contain 2 arguments (not 3, as it was changed with #106916).

The label can stay removed in "main" (v14), but is now re-added
to 13.4 because of this requirement. Without it, the existing (wrong)
localization for older 13.4 versions cannot deliver an update to the
translation.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Oliver Klee +1
    • Peter Kraume +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Oliver Klee +1
    • Peter Kraume +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 56

  1. Garvin Hicking uploaded patch set 1 07/02/25, 14:43

    Oh the heat
  2. Oliver Klee voted on patch set 1 CR +1 V +1 07/02/25, 14:49

  3. core-ci voted on patch set 1 V +1 07/02/25, 14:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81250

  4. Peter Kraume voted on patch set 1 CR +1 V +1 07/03/25, 06:47

  5. Benjamin Franzke commented on patch set 1 CR +2 V +2 07/03/25, 10:59

    Thanks for taking care!
  6. Benjamin Franzke merged patch set 2 07/03/25, 10:59