Review main Merged

89976[BUGFIX] Avoid DefaultRestrictionContainer in installtool session

Benjamin Franzke CR +2 V +2 Easy +16 −27 updated 07/03/25, 06:33

Commit message

Since #106867 the DefaultRestrictionContainer must not be
used without TCA Schema being loaded or available via
TcaSchemaFactory. Refactor the installtool session service
to perform permissions checks manually instead of faking
TCA when TCA has (and can) not be loaded.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Christian Kuhn +1
    • Benni Mack +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Christian Kuhn +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 79

  1. Benjamin Franzke uploaded patch set 1 07/02/25, 14:55

  2. core-ci voted on patch set 1 V +1 07/02/25, 15:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81251

  3. Benjamin Franzke uploaded patch set 2 V +1 07/02/25, 15:18

  4. core-ci voted on patch set 2 V +1 07/02/25, 15:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81252

  5. Benni Mack voted on patch set 2 CR +1 V +1 07/02/25, 16:34

  6. Christian Kuhn commented on patch set 2 CR +1 V +1 07/02/25, 17:06

    like. this is much cleaner than before.
  7. Christian Kuhn commented on patch set 2 07/02/25, 17:14

    note: since the fake TCA solution was hard coded before already, it does not matter with this patch, but let's have this stated once: unsetting ctrl-disabled or ctrl-deleted and probably ctrl-starttime/endtime on central core tables like be_users, be_groups and probably pages and tt_content is de-facto unsupported by core. we may want to keep this in mind and eventually communicate and sanitize this (maybe add a check into TcaPreparation?). i'm raising this since i came across this with dbdoctor already and added a note about this in its readme.
  8. Benjamin Franzke voted on patch set 2 CR +2 V +2 07/03/25, 06:33

  9. Benjamin Franzke merged patch set 3 07/03/25, 06:33