89983[TASK] Replace $_FILES with PSR-7 UploadedFile in ExtendedFileUtility
Commit message
Review
-
Code review CR +2 Done
- Oliver Hader +2
- Garvin Hicking +1
- Stefan Bürk +1
- Benni Mack +1
- Simon Schaufelberger +1
-
Verified V +2 Done
- Oliver Hader +2
- Garvin Hicking +1
- Stefan Bürk +1
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 9
- typo3/sysext/backend/Classes/Controller/File/FileController.php+4 −4
- typo3/sysext/core/Classes/Resource/ResourceStorage.php2+16 −7
- typo3/sysext/core/Classes/Utility/File/ExtendedFileUtility.php2+56 −76
- typo3/sysext/core/Tests/Functional/Utility/File/Fixtures/temp.jpgnewbinary
- typo3/sysext/core/Tests/Functional/Utility/File/Fixtures/temp.pngnewbinary
- typo3/sysext/core/Tests/Functional/Utility/File/Fixtures/temp.svgnew+4 −0
- typo3/sysext/core/Tests/Functional/Utility/File/ExtendedFileUtilityTest.php+203 −0
- typo3/sysext/filelist/Classes/Controller/FileListController.php+1 −1
- typo3/sysext/impexp/Classes/Controller/ImportController.php+1 −1
Review log 2734
Show 69 earlier messages
-
Oliver Hader uploaded patch set 1 07/03/25, 13:55
-
Oliver Hader marked it work in progress 07/03/25, 13:55
-
core-ci voted on patch set 1 V -1 07/03/25, 14:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81282
-
Oliver Hader uploaded patch set 2
V -107/03/25, 16:48 -
core-ci voted on patch set 2 V +1 07/03/25, 16:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81285
-
Oliver Hader uploaded patch set 3
V +107/03/25, 18:54 -
Oliver Hader commented on patch set 3 07/03/25, 18:56
This change is ready for review.@simonschaufi+typo3@gmail.com As requested in https://review.typo3.org/c/Packages/TYPO3.CMS/+/89740, I'm happily introducing new tests for `ExtendedFileUtility` in combination with the required move towards `UploadedFile` models. Looking forward to your review & feedback. Thx -
core-ci voted on patch set 3 V +1 07/03/25, 19:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81287
-
Oliver Hader uploaded patch set 4
V +107/03/25, 19:02
-
core-ci voted on patch set 4 V +1 07/03/25, 19:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81288
-
Garvin Hicking commented on patch set 4 CR +1 V +1 07/03/25, 19:31
Nice! Couldn't break it, tried variants with/without sanitization, single/multi file upload, replace, rename. -
Simon Schaufelberger voted on patch set 4 CR +1 07/03/25, 20:04
-
Simon Schaufelberger commented on patch set 4 07/03/25, 20:56
ResourceStorage.php:989this comment doesn't fit for me here as below is no check if this file is uploaded.ExtendedFileUtility.php:1170is it possible to narrow it down as mixed can really be anything? -
Oliver Hader uploaded patch set 5
CR +1V +107/04/25, 07:59 -
Oliver Hader commented on patch set 4 07/04/25, 07:59
ResourceStorage.php:989ReplyDoneExtendedFileUtility.php:1170ReplyDone -
core-ci voted on patch set 5 V +1 07/04/25, 08:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81314
-
Simon Schaufelberger voted on patch set 5 CR +1 07/04/25, 08:07
-
Garvin Hicking voted on patch set 5 CR +1 V +1 07/04/25, 12:23
-
Simon Schaufelberger commented on patch set 5 07/08/25, 09:50
merge conflict -
Garvin Hicking uploaded patch set 6
CR +1V +107/08/25, 10:00 -
Garvin Hicking commented on patch set 6 07/08/25, 10:02
Reply
just a quick shot at rebasing, didn't check fully yet. -
Oliver Hader commented on patch set 6 07/08/25, 10:03
Reply
I'll adjust the tests... -
Oliver Hader voted on patch set 6 CR -1 07/08/25, 10:05
-
core-ci voted on patch set 6 V -1 07/08/25, 10:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81481
-
Oliver Hader uploaded patch set 7
CR -1V -107/08/25, 10:17 -
Oliver Hader commented on patch set 7 07/08/25, 10:20
Reply
Done -
core-ci voted on patch set 7 V +1 07/08/25, 10:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81482
-
Benni Mack voted on patch set 7 CR +1 V +1 07/08/25, 12:36
-
Garvin Hicking voted on patch set 7 CR +1 V +1 07/08/25, 12:47
-
Stefan Bürk voted on patch set 7 CR +1 V +1 07/08/25, 12:50
-
Simon Schaufelberger voted on patch set 7 CR +1 07/08/25, 12:57
-
Oliver Hader voted on patch set 7 CR +2 V +2 07/08/25, 13:31
-
Oliver Hader commented on patch set 7 07/08/25, 13:31
Thx folks! 😊 -
Oliver Hader merged patch set 8 07/08/25, 13:32