Review main Abandoned

89984[TASK] Remove duplicate capability methods

Oli Bartsch CR +1 V +1 Hard +192 −192 updated 10/14/26, 13:39

Commit message

The Schema API has been public since #107001.
The methods `isLanguageAware()` and `isWorkspaceAware()`
duplicated the central `hasCapability()` like
used for all other capability checks.

To streamline the API and avoid confusion, these
methods have been removed. This ensures DX guides
consistently to use `hasCapability()`.

Review

  • Code review CR +1
    • Benjamin Franzke +1
  • Verified V +1
    • Benjamin Franzke +1
    • core-ci +1 CI

Issues 2

Files 52

Show 32 more files

Review log 1014

  1. Oli Bartsch uploaded patch set 1 07/03/25, 14:42

  2. core-ci voted on patch set 1 V +1 07/03/25, 14:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81283

  3. Oliver Klee updated the commit message in patch set 2 V +1 07/03/25, 14:50

  4. Oliver Klee voted on patch set 2 CR +1 V +1 07/03/25, 14:50

  5. core-ci voted on patch set 2 V +1 07/03/25, 14:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81284

  6. Benjamin Franzke commented on patch set 2 07/04/25, 04:33

    I think there is no advantage in postponing the decision. Let's make the decision now: * Either abandon and keep these methods for sake of simplicity or * Remove right away and replace all usages I don't care much (but I'm in favor of removing), but I'm sure we should decide now.
  7. Oli Bartsch uploaded patch set 3 CR +1 V +1 07/04/25, 07:26

  8. core-ci voted on patch set 3 V -1 07/04/25, 07:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81310

  9. Oli Bartsch uploaded patch set 4 V -1 07/04/25, 07:40

  10. Oli Bartsch commented on patch set 4 07/04/25, 07:44

    Reply

    Oke. Let's remove them now.
  11. core-ci voted on patch set 4 V +1 07/04/25, 07:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81311

  12. Benjamin Franzke commented on patch set 4 CR +1 V +1 07/15/25, 10:56

    DataMapProcessor.php:1478

    adding parentheses looks like an implicit bugfix, but is functionally equivalent. Ok for me..
  13. Benni Mack commented on patch set 4 10/14/26, 12:33

    no offense, but this has been stalled for a long time, and I suggest to abandon this change. The reason why I'm not voting +1 for it - as a summary - is that these methods are - yes, shorthand methods - there because they reflect the two dimensions (= think of overlays) we deal with in TYPO3, and we don't have any other dimensions in this regard, that's why they are needed that often. If you want to rebase and continue, feel free to do so, but just wanted to come back and re-state my opinion on this change.
  14. Oli Bartsch abandoned the change 10/14/26, 13:39

    There are more important topics.